I believe that reliance of property sheet support on setPageId() is incidental. I will take a deeper look shortly.
- Konstantin
From: sapphire-dev-bounces@xxxxxxxxxxx [mailto:sapphire-dev-bounces@xxxxxxxxxxx] On Behalf Of Shenxue Zhou
Sent: Tuesday, May 29, 2012 8:53 AM
To: Sapphire project
Subject: Re: [sapphire-dev] properties view contributions
The regression seems to be caused by changes to ArchitectureEditor alone. The call to setPageId() was removed. SapphireEditor’s setPageId() would establish a link between the page object and the sapphire page part. That link is essential to drive the properties sheet.
In my adopter product, I also need to call setPageId() in the editor class for the properties sheet to work.
Perhaps SapphireEditor’s addPage() could make a call to setPageId() using the page title? That way, adotper’s editor class doesn’t need to make setPageId() call explicitly. But that requires the uniqueness of page tiles.
Shenxue
From: Konstantin Komissarchik
Sent: Tuesday, May 29, 2012 8:43 AM
To: Sapphire project
Subject: Re: [sapphire-dev] properties view contributions
Could you file a bug report for this?
Konstantin Komissarchik
Senior Development Manager
Hey everyone,
I believe that the recent changes to SapphireEditor and the registration of diagram pages has broken the property page contributions. To see this load the architecture editor and notice that selecting the diagram nodes doesn't display the correct properties view. So it looks like SapphireEditor#partByPage map doesn't contain the SapphireDiagramEditor at the time it is expected so the listener for setting the property page based on diagram page selection is never attached. I can work around this issue in my adopter product by specifically setting setPageId() but just wanted to mention it that the ArchitectureEditor is not working as expected.
