Re: [riena-dev] Riena logging reminder...

[Stefan Liebig <Stefan.Liebig@xxxxxxxxxxxx>]

Hi Elias,

Of course, I just forgot them.

Tschüß,
Stefan

Am 02.07.2009 um 20:50 schrieb Elias Volanakis:

> Thanks Stefan.
>
> Should we do the same for IRienaActivator and AbstractRienaUIPlugin ?
>
> Elias.
>
> On Thu, Jul 2, 2009 at 1:41 AM, Stefan Liebig<Stefan.Liebig@xxxxxxxxxxxx 
> > wrote:
> > Has been deprecated in head.
> >
> > Tschüß,
> > Stefan
> >
> > Elias Volanakis wrote:
> >
> > Hi Stefan,
> >
> > +1 for deprecating in IRienaActivator.
> >
> > Removal should not be possible until we decide to break APIs.
> >
> > Kind regards,
> > Elias.
> >
> > On Wed, Jul 1, 2009 at 10:44 PM, Stefan
> > Liebig<Stefan.Liebig@xxxxxxxxxxxx> wrote:
> >
> >
> > Hi Elias,
> >
> > Good reminder!
> > Do you think we should deprecate (or remove) the possibility of (b)?
> >
> > Tschüß,
> > Stefan
> >
> > Elias Volanakis wrote:
> >
> >
> > Please remember to use this style when logging:
> >
> > (a) private static final Logger LOGGER =
> > Log4r.getLogger(Activator.getDefault(), Foo.class);
> >
> > instead of:
> >
> > (b) private static Logger LOGGER =
> > Activator.getDefault().getLogger(Foo.class);
> >
> > The advantage is that Stefan's Log4r also works when not running as a
> > bundle. The second style will fail with a NPE because
> > Activator.getDefault() will be null in that case.
> >
> > :-)
> >
> > Greetings from Portland,
> > Elias.
> >
> >
> >
> >
> > _______________________________________________
> > riena-dev mailing list
> > riena-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/riena-dev
> >
> >
> >
> >
> >
> > _______________________________________________
> > riena-dev mailing list
> > riena-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/riena-dev
>
>
>
> --
> Elias Volanakis | Technical Lead | EclipseSource Portland
> elias@xxxxxxxxxxxxxxxxx | +1 503 929 5537 | http://eclipsesource.com
> _______________________________________________
> riena-dev mailing list
> riena-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/riena-dev