AW: [riena-dev] RienaDialog vs DialogView

["Schepp, Frank" <Frank.Schepp@xxxxxxxxxxxx>]

Hi Elias, Carsten,

DialogView *has* a RienaDialog to provide it with the riena look and feel. So if DialogView is subclass of org.eclipse.jface.dialogs.Dialog either it has to use RienaDialog to delegate for look and feel or there is no riena look and feel. Or DialogView has to be a subclass of RienaDialog!?

Regards, Frank

-----Ursprüngliche Nachricht-----
Von: riena-dev-bounces@xxxxxxxxxxx [mailto:riena-dev-bounces@xxxxxxxxxxx] Im Auftrag von Elias Volanakis
Gesendet: Freitag, 8. Mai 2009 17:10
An: Riena Developers list
Betreff: Re: [riena-dev] RienaDialog vs DialogView

Hi Carsten,

thanks for the input.

+1 for refactoring. I will open a bugzilla so we remember this for after 1.1.0.

My suggestion would be to make the RienaDialog package public and have
DialogView extend Dialog.

Kind regards,
Elias.


On Fri, May 8, 2009 at 12:17 AM, Drossel, Carsten
<Carsten.Drossel@xxxxxxxxxxxx> wrote:
> Hi Elias,
>
> looking at the references it appears that a RienaDialog is a part of a DialogView and used by nobody else.
>
> A DialogView is similar to a SubModuleView: it contains widgets and it is associated with a controller into which Ridgets are injected to control the widgets. The difference is the relation to the actual SWT container. A SubModuleView *is* a SWT ViewPart while a DialogView *has* a RienaDialog which is a subclass of the JFace Dialog.
>
> This appears to be an inconsistency. Maybe we could change the DialogView to be a subclass of org.eclipse.jface.dialogs.Dialog but that would require some refactoring since DialogView already has a superclass.
>
> Hope that clears things up a bit...
> Carsten
>
>
>> -----Ursprüngliche Nachricht-----
>> Von: riena-dev-bounces@xxxxxxxxxxx [mailto:riena-dev-
>> bounces@xxxxxxxxxxx] Im Auftrag von Elias Volanakis
>> Gesendet: Freitag, 8. Mai 2009 06:38
>> An: Riena Developers list
>> Betreff: [riena-dev] RienaDialog vs DialogView
>>
>> Hi Rienaers,
>>
>> I've been looking at the HelloDialogView (opened DialogSubModuleView)
>> which is a subclass of DialogView < AbstractControlledView. We also
>> have a RienaDialog.
>>
>> I'm just curious: what is the difference? What is the use for each?
>>
>> Curious to hear more info,
>> Elias.
>>
>> --
>> Elias Volanakis | Technical Lead | EclipseSource Portland
>> elias@xxxxxxxxxxxxxxxxx | +1 503 929 5537 | http://eclipsesource.com
>> _______________________________________________
>> riena-dev mailing list
>> riena-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/riena-dev
> _______________________________________________
> riena-dev mailing list
> riena-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/riena-dev
>



-- 
Elias Volanakis | Technical Lead | EclipseSource Portland
elias@xxxxxxxxxxxxxxxxx | +1 503 929 5537 | http://eclipsesource.com
_______________________________________________
riena-dev mailing list
riena-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/riena-dev