Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [rdf4j-dev] JavaEE/JakartaEE and Jetty upgrade
Hi Erik,

I’ll try to find some time to look over your PR.

I think Jeen is away for a few week. I have some things coming up and will fairly soon have to take a little break from RDF4J as well. So if you don’t hear much from us then you know why. 

The upgrade of jetty I presume is mostly for our test I assume, if that’s the case then there it’s fine to include it in the same PR as the rest of the Jakarta EE stuff. We don’t necessarily red to make another PR, if you’re able to modify your current PR instead. Feel free to rebase/squash/clean up your branch if you want, just double check that there aren’t any other branches that branch off of your branch before you force push. 

Cheers,
Håvard

On 22 May 2023, at 23:02, Erik Godding Boye <egboye@xxxxxxxxx> wrote:


Hi,

I am seeking input as to what I should do with https://github.com/eclipse/rdf4j/pull/4397! As I have invested quite a lot in preparations for this PR, I would love to see the changes merged somehow.
The CI is now green, and the changes will (almost) resolve https://github.com/eclipse/rdf4j/issues/3559 (dependency wise, not imports) and https://github.com/eclipse/rdf4j/issues/4252.

First of all, I wonder if the hack to overcome the potential Solr/ES upgrade blocker is acceptable or not. If not, I would love to get some suggestions on how to solve this issue.

Secondly, I think it makes the most sense to create a new PR and link it to https://github.com/eclipse/rdf4j/issues/4252 (upgrade to Jetty 10), but also let the PR close https://github.com/eclipse/rdf4j/issues/3559 (Jakarta migration). An alternative would be to separate the two changes, but that will be slightly more work for me - as there is no BOM for JavaEE, and version 8 is the first version of JakartaEE. WDYT?

Regards,
Erik
_______________________________________________
rdf4j-dev mailing list
rdf4j-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/rdf4j-dev

Back to the top