| Re: [rdf4j-dev] [GSOC 2017] #743 -Add support for Shapes Constraint Language (SHACL) |
Thank you! :)On Mon, Apr 17, 2017 at 3:17 PM, Håvard Ottestad <hmottestad@xxxxxxxxx> wrote:Found it :PLooks like you have shacl twice in the Pom file.Hi Håvard,I go though RDF4J SAIL documentations and there implementations methods.After that I create my basic folders and classes as my first step.You can see my first steps in the following picture.I have a small problem in this place.perviously implemented SailConnection classes(core/spain/src/main/java/org.eclipse.rdf4j/sail/spai n) treated as java classes but newly created Shape classes and SHACL classes are not treated as java classes by IDE. It don't give any suggestions,do not give any override methods.i manually import other classes to my new classes but still it do not support as java classes.I think my newly created packages not working as java packages. <Screen Shot 2017-04-16 at 7.34.21 PM.png>in this Github also it shows in different way.<Screen Shot 2017-04-16 at 8.01.00 PM.png>my pom.xml look like this<Screen Shot 2017-04-16 at 8.03.48 PM.png>
do you know any solution to this problem?Thank you!regards,Heshan
On Mon, Apr 10, 2017 at 7:47 PM, Håvard Ottestad <hmottestad@xxxxxxxxx> wrote:Let's start with Wednesday at 5pm Oslo time.
HåvardHi Håvard,Shall we take our first panning call on this Tuesday(11th of Apr) or Wednesday(12th of Apr) at 5 pm Oslo time? Then I have time to research on those areas in our new year season.If other RDF4J developers like to join with us,Hope we can do another discussion on 19th, 20th or 21st.I have exams in the mid of May so I plan to finish some areas before the exam season because I need few days to do my studies.I like to speed up the current process and finish some tasks.Please let me know your preferred day and time.i'll join the hangouts call on that timeThank you!regards,HeshanOn Sun, Apr 9, 2017 at 5:56 PM, Håvard Ottestad <hmottestad@xxxxxxxxx> wrote:I'll be available Monday to Wednesday this coming week. From 5 pm Oslo time. After that it's easter break in Norway, so the next time I can meet you will be on Wednesday.You said you also had some holidays in Sri Lanka, so I propose we try for a meeting on the 19th, 20th or 21st after 5pm. One of those days I might end up being busy in the evening due to it being the final week for a member of our project team and we're going out for a dinner. Not sure which day it's going to be though.*** To the RDF4J developers *** if any of you have any input as to the architecture of the SHACL module it would be great if you could write by then, or join the hangouts call (let me know and I'll give you a link). As outlined in the proposition; Heshan is trying for a DB style architecture with an AST and "query" planner with a subsequent optimisation step, all for the purpose of limiting the number of rules that need to be run and the amount of data to be fetched from the underlying store.HåvardOn Sat, Apr 8, 2017 at 11:48 AM, Heshan Jayasinghe <shanujse@xxxxxxxxx> wrote:Hi Håvard,Yes,when do you have free time take a skype call?Hope we can plan the folder structures,high level architecture of the feature and other subparts of the features.Thank you!regards,HeshanOn Thu, Apr 6, 2017 at 10:39 PM, Håvard Ottestad <hmottestad@xxxxxxxxx> wrote:Hi Heshan,You want another video call?Your approach looks good. Just remember that you are trying to model the AST for SHACL. This means that you have the concept of Shape and Property Constraint where shape can have multiple properties, and properties can have a maxCount or minCount etc. You'll want to think about inheritance and interfaces. But keep it simple, you can expand it later when you see the need. That'll feel better than having to remove and rewrite a bunch of code and setup you made up front because it doesn't work anymore.
HåvardHi Håvard,I like to start this new feature from now onwards. This feature focus on performance so before going to implementation I like to have a small planing discussion.I discuss with Jeen about folder location for this feature and he suggest me to implement on core/sail/shacl or core/shacl.I think core/shacl location is good place to do this implementation because this feature include more new modules.following folder structure is my suggestion.I think there should more classes than this.core|-shacl| |-components| | |-src/main/java/org.eclipse.rdf4j.shacl.components | | | |-MinCount| | | |-MaxCount| | | |-Class| | | |-Datatype| | | |-Logical_Or| | | |-Logical_And| | | |-Logical_Not| | |-pom.xml| || | -shapes| | |-src/main/java/org.eclipse.rdf4j.shacl.shapes | | | |-TargetClass| | | |-Property| | | |-Path| | |-pom.xml| || | -sail| | |-src/main/java/org.eclipse.rdf4j.shacl.sail | | | |-SHACLSail| | |-pom.xml| || | -violation| | |-src/main/java/org.eclipse.rdf4j.shacl.violation | | | |-ShaclViolationListener| | |-pom.xml| || | -base| |-src/main/java/org.eclipse.rdf4j.shacl.base | | |-BaseShape| |-pom.xmlfor test-casestestsuites|-shacl|-src/main/java/org.eclipse.rdf4j.shacl |-MinCount|-MaxCount|-Class|-Datatype|-Logical_Or|-Logical_And|-Logical_Not|-TargetClass|-Property|-PathCan you please give me suggestions for this folder structure and what else I should focus on this planning discussion?Thank You!regards,Heshan