Re: [rdf4j-dev] [GSOC 2017] #743 -Add support for Shapes Constraint Lang

[Håvard Ottestad <hmottestad@xxxxxxxxx>]

Hi Heshan,

You want another video call?

Your approach looks good. Just remember that you are trying to model the AST for SHACL. This means that you have the concept of Shape and Property Constraint where shape can have multiple properties, and properties can have a maxCount or minCount etc. You'll want to think about inheritance and interfaces. But keep it simple, you can expand it later when you see the need. That'll feel better than having to remove and rewrite a bunch of code and setup you made up front because it doesn't work anymore. 

Håvard

On 6 Apr 2017, at 01:08, Heshan Jayasinghe <shanujse@xxxxxxxxx> wrote:

Hi Håvard,

I like to start this new feature from now onwards. This feature focus on performance so before going to implementation I like to have a small planing discussion.

I discuss with Jeen about folder location for this feature and he suggest me to implement on core/sail/shacl or core/shacl.I think core/shacl location is good place to do this implementation because this feature include more new modules.

following folder structure is my suggestion.I think there should more classes than this.

core

  |-shacl

  |   |-components

  |   |     |-src/main/java/org.eclipse.rdf4j.shacl.components

  |   |     |                 |-MinCount

  |   |     |                 |-MaxCount

  |   |     |                 |-Class

  |   |     |                 |-Datatype

  |   |     |                 |-Logical_Or

  |   |     |                 |-Logical_And

  |   |     |                 |-Logical_Not

  |   |     |-pom.xml

  |   | 

  |   | -shapes

  |   |     |-src/main/java/org.eclipse.rdf4j.shacl.shapes

  |   |     |                  |-TargetClass

  |   |     |                  |-Property

  |   |     |                  |-Path

  |   |     |-pom.xml

  |   | 

  |   | -sail

  |   |     |-src/main/java/org.eclipse.rdf4j.shacl.sail

  |   |     |                  |-SHACLSail

  |   |     |-pom.xml

  |   | 

  |   | -violation

  |   |     |-src/main/java/org.eclipse.rdf4j.shacl.violation

  |   |     |                  |-ShaclViolationListener

  |   |     |-pom.xml

  |   | 

  |   | -base

  |         |-src/main/java/org.eclipse.rdf4j.shacl.base

  |         |                  |-BaseShape

  |         |-pom.xml

for test-cases 

testsuites

  |-shacl

      |-src/main/java/org.eclipse.rdf4j.shacl

                           |-MinCount

                           |-MaxCount

                           |-Class

                           |-Datatype

                           |-Logical_Or

                           |-Logical_And

                           |-Logical_Not

                           |-TargetClass

                           |-Property

                           |-Path

Can you please give me suggestions for this folder structure and what else I should focus on this planning discussion?

Thank You!

regards,

Heshan