Re: [qvto-dev] Bug 422273 review

[Sergey Boyko <serg.boyko2011@xxxxxxxxx>]

Hi Ed,

I don't understand which "source errors" you mean.  I'm using Luna M3 as target platform and everything compiles without errors.  

Compilation problems which were caused by changes in ILaunchConfiguration has been fixed with commit "c3a7aa620c55f9f117667b7e36bff35c61056730" 4 month ago.

I reviewed patch you proposed and to me it looks the follows:

- I didn't find fixes of real compilation errors, there are simply replaces of Map<String, Object> with Map<String, String> in various places.

- It changes IContext (API interface) with no particular reason for it. Note that this interface is not associated with ILaunchConfiguration and limitation in the latter doesn't affect it.

Regards,

Sergey Boyko

On Thu, Dec 12, 2013 at 2:39 PM, Ed Willink <ed@xxxxxxxxxxxxx> wrote:

Hi

It seems no one is using Luna milestone tooling, otherwise https://bugs.eclipse.org/bugs/show_bug.cgi?id=422273 would have been reviewed by now.

Most of the changes are trivial but a couple are a bit smelly.

I've rebased on master to aid review/integration.

    Regards

        Ed
_______________________________________________
qvto-dev mailing list
qvto-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/qvto-dev