Greg,
Three questions:
1. This adds about 60,000 LOC. It is mostly the work of students at Auburn. I added Also-by: lines to the commit comment. I suppose it needs to go through an IP/provenance review…?
Yes, this will need a CQ.
2. In addition to the Eclipse features, this includes the ability to run refactorings from the command line. The CLI tool can be built into a JAR, but to do so, the included Ant script needs some JARs from CDT, the platform, etc. I committed the JARs from the specific version of Eclipse we actually tested with. It feels wrong to be committing JARs to the repo, but OTOH, the CLI project won't compile unless they are present, and the versions are important. Should I leave them in or take them out?
The problem with committing jars is that they’re going to go out of date pretty fast or you will need to keep updating them. Is it possible for the CLI tool to fetch them from the simrel repo instead?
3. We'd like to include this in the September release. There is no new API (intentionally). Does this mean the version number will increase to 9.2?
It’s a line call. Since there’s no API change, you are really only required to increment the plugin service number, and consequently we could release PTP for Neon.1 as 9.1.1. A 9.2 release requires a release review (minor), but this wouldn’t be a big issue if you wanted to go that way.
_______________________________________________ ptp-dev mailing list ptp-dev@xxxxxxxxxxxTo change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/ptp-dev
|
