Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ptp-dev] GUI Terminal/Gerrit
My attempt to commit with amend failed. Perhaps this is because I did a git pull, in an effort to make sure nothing changed underneath my feet.

In any event, I'm now back to the situation in which it insists that I haven't signed off, even if I copy the sign off text from my previous commit.

I saw that I was 3 commits ahead, and tried to fix this the same way I did the last time.

   git rebase -i HEAD~3

I was expecting to see a list of my commits. Instead, I saw all the commits since my initial commit (much more than 3, which also surprised me). I left everything alone, i.e. I picked everything, but apparently the rebase still changed something. This is different than what I remember happening last time I attempted this same thing.

The result is that I still can't commit because git says I didn't signed-off. Not sure what to do.

I think my biggest problem is that I only understand enough git to be dangerous.

Cheers,
Steve

On 10/30/2013 07:55 PM, Roland Schulz wrote:



On Wed, Oct 30, 2013 at 6:25 PM, Steven R. Brandt <sbrandt@xxxxxxxxxxx> wrote:
I've gone through https://git.eclipse.org/r/#/c/17427/ and fixed all but
one of the comments. Greg commented on plugin.xml taht the
preferencesPages should go in the "Remote Development" category.

I don't know what this means, and replied in Gerrit to that effect, but
my reply is labeled "Draft." I don't know if "Drafts" are visible to
others, or what I can do to get replies to not be labeled "Draft."
No. You have to click "Add Comment"->"Publish Comments" 

My next question is, how do I upload the new changes into gerrit? Can I
just do another push and will the review status reset?
Yes. You commit with amend and then you push.
 

Cheers,
Steve
_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev







--
ORNL/UT Center for Molecular Biophysics cmb.ornl.gov
865-241-1537, ORNL PO BOX 2008 MS6309 


_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev

Back to the top