Re: [ptp-dev] bug fixes

[Greg Watson <g.watson@xxxxxxxxxxxx>]

You could revert the commit, then commit again with a new comment. I'm not sure this is worth the trouble though.

Greg

On Jun 4, 2013, at 4:32 PM, Wyatt Spear <wspear@xxxxxxxxxxxxxx> wrote:

I've made some more substantial commits recently. Is there anything I can do besides retroactively file a bug?

=Wyatt

On Tue, Jun 4, 2013 at 7:49 AM, Christopher Navarro <cmnavarr@xxxxxxxxxxxx> wrote:

It was a 1 line fix and it's already pushed so I think the easiest solution if there are no objections might be to open a bug, add a comment above the line where I made the change and the commit that. Amending the commit for a 1 line change sounds painful :)

Chris

On 06/04/2013 09:29 AM, Beth Tibbitts wrote:

If you haven't PUSHed yet, you can edit the comment in the git commit dialog, use the first icon up on the right on the same line as the "Commit message" label
Hover over it to see "Amend previous commit"
I'm not sure about after a push.

They changed the UI since this: http://wiki.eclipse.org/EGit/User_Guide#Amending_Commits
It's not a checkbox it's the little toolbar up on the right now


...Beth

Beth Tibbitts
Eclipse Parallel Tools Platform  http://eclipse.org/ptp
IBM STG - High Performance Computing Tools
Mailing Address:  IBM Corp., 745 West New Circle Road, Lexington, KY 40511

<Mail Attachment.gif>Christopher Navarro ---06/04/2013 10:20:33 AM---Is there a way to edit a git commit comment? I checked in a small fix  for the profiling launch dele

<Mail Attachment.gif> From:	<Mail Attachment.gif> Christopher Navarro <cmnavarr@xxxxxxxxxxxx>
<Mail Attachment.gif> To:	<Mail Attachment.gif> Parallel Tools Platform general developers <ptp-dev@xxxxxxxxxxx>
<Mail Attachment.gif> Date:	<Mail Attachment.gif> 06/04/2013 10:20 AM
<Mail Attachment.gif> Subject:	<Mail Attachment.gif> Re: [ptp-dev] bug fixes
<Mail Attachment.gif> Sent by:	<Mail Attachment.gif> ptp-dev-bounces@xxxxxxxxxxx

---

Is there a way to edit a git commit comment? I checked in a small fix
for the profiling launch delegate and didn't realize I should have
opened a bug first. Should I do so and edit the commit comment (if
possible)?

Thanks,
Chris

On 06/04/2013 07:36 AM, Greg Watson wrote:
> And I forgot to add, please ensure that the commit comment has the bug number at the beginning of the comment.
>
> Thanks,
> Greg
>
> On Jun 4, 2013, at 1:35 PM, Greg Watson <g.watson@xxxxxxxxxxxx> wrote:
>
>> I've noticed that quite a number of the fixes being committed to the master branch do not have bug numbers in the comment. At this stage (RC3) most, if not all, commits should be to fix problems that have been opened as bugs. If a bug is not open for the thing you are fixing, then please ensure that it is before you commit the fix.
>>
>> Thanks,
>> Greg
> _______________________________________________
> ptp-dev mailing list
> ptp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/ptp-dev
>

_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev

_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev

_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev

_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev