[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [ptp-dev] About to commit major change to Attributes on HEAD
|
The commit will commence now. Actually the commit
will probably happen before you get this email.
R^2
On Wed, 2007-05-30 at 08:17 -0600, Greg Watson wrote:
> Randy,
>
> Would you be able to commit this today? I have large number of
> changes that is growing. I'd like to update before it gets out of hand.
>
> Greg
>
> On May 29, 2007, at 5:26 PM, Randy M. Roberts wrote:
>
> > Dave, Greg, Craig, others concerned,
> >
> > I am about to commit a major change in the Attribute system.
> > It covers 93 files.
> >
> > Attributes and AttributeDefinitions are now parameterized by
> > three types, e.g. the new definition for IAttribute is
> >
> > public interface IAttribute<T, A extends IAttribute<T,A,D>, D extends
> > IAttributeDefinition<T,A,D>>
> > extends Comparable<A> {
> >
> > /**
> > * @return the attribute definition object associated with this
> > attribute
> > */
> > public D getDefinition();
> >
> > /**
> > * @return
> > */
> > public T getValue();
> >
> > /**
> > * @return string
> > */
> > public String getValueAsString();
> >
> > /**
> > * @return whether any UI elements for this attribute
> > * should be enabled.
> > */
> > public boolean isEnabled();
> >
> > /**
> > * Is the string parsable to a valid
> > * attribute of this type?
> > *
> > * @param string
> > * @return
> > */
> > public boolean isValid(String string);
> >
> > /**
> > * @param value
> > * @throws IllegalValueException
> > */
> > public void setValue(T value) throws IllegalValueException;
> >
> > /**
> > * @param string
> > * @throws IAttribute.IllegalValue
> > */
> > public void setValueAsString(String string) throws
> > IllegalValueException;
> > }
> >
> > The same change has been made for AttributeDefinition's.
> >
> > Also note that ArrayAttribute is parameterized on its
> > contained type. Its getValue() now returns a List<T> instead of
> > T[].
> >
> > Let me know if there is any reason not to commit these changes.
> >
> > Regards,
> > Randy
> > --
> > Randy M. Roberts
> > rsqrd@xxxxxxxx
> > work: (505)665-4285
> >
> > "They that can give up essential liberty to obtain a little temporary
> > safety deserve neither liberty nor safety." -- Benjamin Franklin
> >
> > _______________________________________________
> > ptp-dev mailing list
> > ptp-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/ptp-dev
>
> _______________________________________________
> ptp-dev mailing list
> ptp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/ptp-dev
