Re: [platform-ui-dev] Policy of the Platform projects with regards to te

["David M Williams" <david_williams@xxxxxxxxxx>]

I'd like to suggest a slightly different
approach. Instead of "adjusting the test project" that it might
be easier to "add a new test bundle as a fragment". 

Perhaps this will not work for what
you had in mind? But if so, I am suggesting it since most of our tests
fit into the "Test Runner" framework (and ran on different platforms,
after the build). 
While I am sure the fragment approach
could be made to work in that case too, in sounds like a larger change,
and a larger amount of work to "confirm all the old stuff is working"
 instead of 
simply making sure the new stuff is
working. 

Just a suggestion -- if it makes things
easier. 




From:      
 Lars Vogel <lars.vogel@xxxxxxxxxxx>
To:      
 "Eclipse Platform
UI component developers list." <platform-ui-dev@xxxxxxxxxxx>
Date:      
 03/08/2016 10:10 AM
Subject:    
   Re: [platform-ui-dev]
Policy of the Platform projects with regards to tests accessing non-public
members
Sent by:    
   platform-ui-dev-bounces@xxxxxxxxxxx

---

Thanks Szymon, Bruno is this case it would be OK to adjust
the test project

Am 08.03.2016 3:52 nachm. schrieb "Szymon Ptaszkiewicz" <szymon.ptaszkiewicz@xxxxxxxxxx>:
The org.eclipse.core.filebuffers plugin is not part of the Platform Resources component. It lives in the eclipse.platform.text repository and is now part of the Platform UI component.

Szymon

Lars Vogel ---2016-03-08 15:47:28---[Re answer from IDE] For Platform UI test projects we can switch to test fragments if this helps

From: Lars Vogel <lars.vogel@xxxxxxxxxxx>
To: "Eclipse Platform UI component developers list." <platform-ui-dev@xxxxxxxxxxx>
Date: 2016-03-08 15:47
Subject: Re: [platform-ui-dev] Policy of the Platform projects with regards to tests accessing non-public members
Sent by: platform-ui-dev-bounces@xxxxxxxxxxx

---

[Re answer from IDE]

For Platform UI test projects we can switch to test fragments if this helps but IIRC filebuffers belongs to the platform.resources so you should ask this project

Am 08.03.2016 3:21 nachm. schrieb "Bruno Medeiros" <bruno.do.medeiros@xxxxxxxxx>:
[Reposting from the IDE-Dev mailing list]

Hi,

I've started recently my first attempt at a big functionality patch for an Eclipse Platform project. Previously I've only submitted very small, trivial patches.

Whilst beginning to write tests for this functionality, I've noticed that nearly all platform.ui and platform.text *test* plugins are separate plugins, and not plugin-fragments of the plugin being tested. This makes it impossible for the test code to directly access non-public members of the plugin being tested (see https://rcpquickstart.wordpress.com/2007/06/20/unit-testing-plug-ins-with-fragments/).

This severely limits the usefulness/potential of what the tests can do, so I'm wondering, is this some official code policy of the Platform projects, is there some limitation prevent them from being converted to fragment bundles, or did simply no one got around to doing it?

Would then a patch to change a test bundle to a fragment be accepted? The tests I'm writing need access to non-public plugin members. (of org.eclipse.core.filebuffers , if you're wondering)

--
Bruno Medeiros
https://twitter.com/brunodomedeiros

_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev


_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev