Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-ui-dev] Anyone mind if I run the code formatteronjface?

EGit also allows you to jump to parent commits via the annotation hover ("show annotations" link for parent commit).

However, this is still painful process you have to do manually each and every time you use Show Annotations, and since the skipping is not done in-place you always have to deal with a set of annotated files instead of just one annotated version that tells it all.

See Bug 392571: Exclude certain (formatting) commits from Show Annotations (blame)

Once a solution for this is available, we can think about formatting whole projects. Before: No.

Markus



From:        Stefan Xenos <sxenos@xxxxxxxxxx>
To:        "Eclipse Platform UI component developers list." <platform-ui-dev@xxxxxxxxxxx>
Date:        2015-12-08 19:01
Subject:        Re: [platform-ui-dev] Anyone mind if I run the code formatter        onjface?
Sent by:        platform-ui-dev-bounces@xxxxxxxxxxx




Blame parent commit is a feature that lets you see what the annotations looked like before a big change like a reformat, so you can identify the author of a line even across large diffs. It's a context menu action in "git gui blame" and it is different from "git blame -w", which ignores whitespace.

The link you attached seems to be discussing "git blame -w".

  - Stefan

On Tue, Dec 8, 2015 at 1:03 AM Daniel Megert <daniel_megert@xxxxxxxxxx> wrote:
> Git has a "blame parent commit" feature intended for exactly this purpose.

See
https://bugs.eclipse.org/bugs/show_bug.cgi?id=478673#c35

Dani




From:        
sxenos@xxxxxxxxx
To:        
Andrey Loskutov <platform-ui-dev@xxxxxxxxxxx>, "Eclipse Platform UI component developers list." <platform-ui-dev@xxxxxxxxxxx>, Stefan Xenos <sxenos@xxxxxxxxxx>
Date:        
08.12.2015 08:54
Subject:        
Re: [platform-ui-dev] Anyone mind if I run the code formatter on        jface?
Sent by:        
platform-ui-dev-bounces@xxxxxxxxxxx




Git has a "blame parent commit" feature intended for exactly this purpose.

Sent from my BlackBerry 10 smartphone.
  Original Message  
From: Andrey Loskutov
Sent: Monday, December 7, 2015 21:52
To: Eclipse Platform UI component developers list.; Stefan Xenos
Reply To: Eclipse Platform UI component developers list.
Subject: Re: [platform-ui-dev] Anyone mind if I run the code formatter on jface?

I would prefer you wouldn't run formatter on existing code. I do not plan any big change, but this would make git blame annotations diff useless and this is a major issue.

Am 8. Dezember 2015 05:07:15 MEZ, schrieb Stefan Xenos <
sxenos@xxxxxxxxxx>:
>Most of the files seem to be inconsistently formatted, which causes
>pain
>whenever the post-save action runs. IMO, it would make sense to
>auto-format
>the lot.
>
>The trouble is, a big change like this will create merge problems if
>there's any big outstanding patches in the queue. Anyone working on
>anything, or should I go ahead?
>
>
>------------------------------------------------------------------------
>
>_______________________________________________
>platform-ui-dev mailing list
>
platform-ui-dev@xxxxxxxxxxx
>To change your delivery options, retrieve your password, or unsubscribe
>from this list, visit
>
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev

--
Kind regards,
Andrey Loskutov

http://google.com/+AndreyLoskutov
_______________________________________________
platform-ui-dev mailing list

platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
_______________________________________________
platform-ui-dev mailing list

platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/platform-ui-dev



_______________________________________________
platform-ui-dev mailing list

platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/platform-ui-dev_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev


Back to the top