Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-ui-dev] [proposal] Unite platform text and UI projects forces
> The same arguments for merging could be brought up for other Platform sub-projects. Maybe in the end merging everything will be the final answer. 

To be honest, I'd be in favor of that, too... but I think the problems are particularly acute for platform text due to the lack of committers.

> However, the drawback is that we loose the publicly declared leadership for those sub-projects and persons being accountable for that code when we merge everything into one pot. 

There's a number of ways to address that.

Option 1: If the number of active committers in a project has dropped below a certain threshold, there's no need for leadership since there's nobody left to lead. So one option would be that small enough projects should just automatically move under the umbrella of another project and the existing leadership of the larger project can take ownership and responsibility for the smaller project. For example, having a management structure to manage the work of 1-2 developers may be needless overhead. With this option, we just disband platform text as a separate entity and add those responsibilities to platform UI.

Option 2: We loosten the coupling between teams and code. We could still have teams responsible for achieving certain deliverables, but they wouldn't need to be tied so tightly to a set of git repositories.

Option 3: Keep the current project structure, but broaden the permissions in gerrit. Allow commiters from one platform team to review and submit code in other repositories, but the "owners" of each platform project still get the final say on what goes in, involvement in all design changes, and the freedom to revert anything from their repository. This would make it easier to do the sort of large-scale-but-trivial changes and obvious bugfixes that make up most cross-team submissions, but would allow us to retain the current leadership structure and team autonomy. Gerrit permissions could still be removed in the unlikely event someone abuses this (most likely, the threat of removal would be sufficient if this ever becomes a problem).

Option 4: Change the leadership. Merge all of platform into a single project with a new reporting structure.

Thoughts?

  - Stefan

On Fri, Oct 9, 2015 at 9:29 AM Daniel Megert <daniel_megert@xxxxxxxxxx> wrote:
> +1 for the merge. There is a bottleneck with code reviews in platform.text. A very important https://git.eclipse.org/r/#/c/21478/ is moving forward very slowly. https://git.eclipse.org/r/#/c/31337/ took 10 weeks to get
> the first feedback.

I will be very happy to see that a Platform UI committer does the complete review (not just comments on whitespace). This can be done without changing anything in the project structure.

Thanks,
Dani



From:        Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx>
To:        "Eclipse Platform UI component developers list." <platform-ui-dev@xxxxxxxxxxx>
Cc:        Eclipse Platform Text component developers list <platform-text-dev@xxxxxxxxxxx>
Date:        09.10.2015 18:21
Subject:        Re: [platform-ui-dev] [proposal] Unite platform text and UI        projects forces
Sent by:        platform-ui-dev-bounces@xxxxxxxxxxx



+1 for the merge. There is a bottleneck with code reviews in platform.text. A very important https://git.eclipse.org/r/#/c/21478/ is moving forward very slowly. https://git.eclipse.org/r/#/c/31337/ took 10 weeks to get the first feedback.

-sergey

On Fri, Oct 9, 2015 at 5:56 AM, Stefan Xenos <sxenos@xxxxxxxxxx> wrote:
+1 from me for the merge. To be honest, I was about to propose the same thing. The high segregation of Eclipse projects makes it hard to perform large-scale cleanup (deal with deprecations, fix formatting, update copyright headers, etc.).

Platform text is such a small project that it would take a long time for any one UI committer to build up enough patches to get nominated for commit rights, but it's a very important one... and having so few committers on it creates an unnecessary bottleneck. Most of the patterns used in platform text are familiar to other UI developers who have worked on concrete text editors, so there would be many people qualified to write good bugfixes when they come up.

The current platform text committers will still be the platform text experts and would be consulted on any design change. The difference would be that they would no longer need to be involved in the "context-free" changes that make up a large portion of contributions to platform text. This would reduce the workload for the current text committers and would reduce the time that such changes need to wait in the queue.

  - Stefan

On Fri, Oct 9, 2015 at 5:10 AM Daniel Megert <daniel_megert@xxxxxxxxxx> wrote:
Hi Andrey

I know your patch is waiting, sorry, it's on my list to be done after the zoom patch.

-1 from me for the merge. I haven't seen many Text related contributions form Platform UI committers that would justify giving access to all Platform UI committers. Changes that are of Text context-free related changes (remove comments, change BREE, etc.) are not Platform Text specific. Having said that, if there are Platform UI committers - or any other contributors - that provide further contributions, or good code reviews over the next time, then I'd be very happy to welcome them as new committers on Platform Text.

Dani



From:        Andrey Loskutov <loskutov@xxxxxx>
To:        platform-text-dev@xxxxxxxxxxx, platform-ui-dev@xxxxxxxxxxx
Date:        09.10.2015 13:56
Subject:        [platform-ui-dev] [proposal] Unite platform text and UI projects        forces
Sent by:        platform-ui-dev-bounces@xxxxxxxxxxx



Hi all,

Recently I was trying to update the platform text projects to BREE 1.7
to get rid of nasty compile problems with incompatible JRE (platform
text still insists to see JRE 1.4 on classpath), see [1], but so far it
didn't found any feedback except the one non-text committer (it was Lars
as usually :-)).

This does not surprise me, especially looking on the project statistics
[2] where one can see that there are actually only 2 active committers
with commit rights on the platform text (Dani and Markus), and the 2
commits which were made from non-project contributors are representing
9% of the project activity in the last 3 months! BTW both those
"external" 2 commits were made by platform UI committers.

So while we all know how overloaded both active platform text committers
are, and how bad our overall state with reviewing bugs and patches etc
is, why not unite our forces and integrate platform text into platform
UI project? Those two projects have really many things in common and it
feels naturally for me if we could allow both teams to work on their
code together. Actually the half of platform text committers are already
platform UI committers, but unfortunately not other way around.

So what do you think?
Does this proposal makes sense for you?

Are platform UI committer ready to take over few projects from platform
text? Are platform text committers agree to give platform UI members
commit rights on platform text and vice versa?

Few data about projects in platform text: 6 projects (without tests),
~1200 files, 4 committers (2 active):

org.eclipse.core.filebuffers
org.eclipse.jface.text
org.eclipse.search
org.eclipse.text
org.eclipse.ui.editors
org.eclipse.ui.workbench.texteditor

For comparison: Platform UI: 38 projects (without tests), ~5200 files,
25 committers (although I guess only half of them are active).

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=478673
[2] https://projects.eclipse.org/projects/eclipse.platform.text/who

--
Kind regards,
Andrey Loskutov

http://google.com/+AndreyLoskutov
_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev


_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev

_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev

Back to the top