Re: [platform-ui-dev] "Best" access modifier for the renderer @PostContr

[Wim Jongman <wim.jongman@xxxxxxxxx>]

Sorry I was reading to fast. I understood you meant the pojo classes in the model but you were talking about internal renderers.

at least it gave me an opportunity to plug my blog post again ;)

Cheers,

Wim

On Thu, Apr 24, 2014 at 10:30 PM, Lars Vogel <lars.vogel@xxxxxxxxx> wrote:

Hi Wim, 

a Pojo can have all possible access modifiers and I don't understand you point. 

Best regards, Lars

2014-04-24 22:19 GMT+02:00 Wim Jongman <wim.jongman@xxxxxxxxx>:

Hi,

Wasn't the whole idea to be able to use Pojo's and not be so dependent on the framework?

See reason 1 of: http://industrial-tsi-wim.blogspot.de/2012/10/why-eclipse-e4-egg-laying-woolmilkpig.html

Cheers,

Wim

On Thu, Apr 24, 2014 at 6:13 PM, Lars Vogel <lars.vogel@xxxxxxxxx> wrote:

Thanks Eric, yes that is my question. I think we should define a common approach for access modifiers for methods which should only be called by the framework.

2014-04-24 16:04 GMT+02:00 Eric Moffatt <emoffatt@xxxxxxxxxx>:

Paul, I think he's talking about the scope (public, private...) for the methods that we use the annotations on...

Since these methods are defined in a manner in which they're being called through DI making them 'public' seems wrong. I guess that they should be scoped like any other method based on whether you expect others to be able to call the method...

Eric


Paul Webster ---04/24/2014 09:17:29 AM---I'm not sure I understand. On Wed, Apr 23, 2014 at 5:44 AM, Lars Vogel <lars.vogel@xxxxxxxxx> wrote:

From:	Paul Webster <pwebster@xxxxxxxxxxxxxxxxxxx>
To:	"Eclipse Platform UI component developers list." <platform-ui-dev@xxxxxxxxxxx>,
Date:	04/24/2014 09:17 AM
Subject:	Re: [platform-ui-dev] "Best" access modifier for the renderer @PostContruct, @PreDestroy and @Inject methods
Sent by:	platform-ui-dev-bounces@xxxxxxxxxxx

---

I'm not sure I understand.


On Wed, Apr 23, 2014 at 5:44 AM, Lars Vogel <lars.vogel@xxxxxxxxx> wrote:

Hi,

in the renderer implementations I currently see a wild mix of access modifier, e.g. private, default, protected and public for methods annotated with @Inject, @PreDestroy and @PostConstruct.

The methods and fields have the modifier on them as appropriate.  The fact that they're marked with @Inject, @PreDestroy or @PostConsturct doesn't really matter, does it?

PW

--
Paul Webster
Hi floor.  Make me a sammich! - GIR _______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev

_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev

_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev

_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev

_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev