Re: [platform-ui-dev] "Best" access modifier for the renderer @PostContr

[Eric Moffatt <emoffatt@xxxxxxxxxx>]

Paul, I think he's talking about the scope (public, private...) for the methods that we use the annotations on...

Since these methods are defined in a manner in which they're being called through DI making them 'public' seems wrong. I guess that they should be scoped like any other method based on whether you expect others to be able to call the method...

Eric


Paul Webster ---04/24/2014 09:17:29 AM---I'm not sure I understand. On Wed, Apr 23, 2014 at 5:44 AM, Lars Vogel <lars.vogel@xxxxxxxxx> wrote:

From:	Paul Webster <pwebster@xxxxxxxxxxxxxxxxxxx>
To:	"Eclipse Platform UI component developers list." <platform-ui-dev@xxxxxxxxxxx>,
Date:	04/24/2014 09:17 AM
Subject:	Re: [platform-ui-dev] "Best" access modifier for the renderer @PostContruct, @PreDestroy and @Inject methods
Sent by:	platform-ui-dev-bounces@xxxxxxxxxxx

---

I'm not sure I understand.


On Wed, Apr 23, 2014 at 5:44 AM, Lars Vogel <lars.vogel@xxxxxxxxx> wrote:

Hi,

in the renderer implementations I currently see a wild mix of access modifier, e.g. private, default, protected and public for methods annotated with @Inject, @PreDestroy and @PostConstruct.

The methods and fields have the modifier on them as appropriate.  The fact that they're marked with @Inject, @PreDestroy or @PostConsturct doesn't really matter, does it?

PW

-- 
Paul Webster
Hi floor.  Make me a sammich! - GIR _______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev