Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-ui-dev] M6 open bugs

... well I have no rush - you know I'm not a fan of the event-vetoing
through the event-bus.

e(fx)clipse will support the platform way but we'll also provide the
version I outlined in the bug.

One of the problems of the events is that you can not scope and so all
listener will be notified which could result in performance problems if
there are listeners who go wild.

So it's completely up to you.

Tom

On 04.03.14 17:35, Eric Moffatt wrote:
> Tom, I've got the changes to add the new events into UIEvents in my
> workspace. I then ran into problems coming up with a 'veto' API because
> our current 'publishEvent' already returns a boolean. Rather than trying
> to 'jam in' that API I decided to hold off on the patch until we could
> go over it. Also, even if we had an answer to that we still haven't
> implemented any of the hooks to publish these events so right now they'd
> be useless.
> 
> I'm fine with checking in the extension to the UIEvents class with any
> veto API for M6 and loosening the rules a bit as far as allowing the
> implementation to take place in M7 but Paul and Dani would have to buy
> into this...We've only really added five events; Deactivate, PreOpen,
> PostOpen, PreClose, PostClose, all of which make sense.
> 
> Back to testing,
> Eric
> 
> 
> Inactive hide details for Tom Schindl ---03/04/2014 06:39:37 AM---Hi, I
> wonder what happened toTom Schindl ---03/04/2014 06:39:37 AM---Hi, I
> wonder what happened to
> 
> 
>     From:
> 
> 	
> Tom Schindl <tom.schindl@xxxxxxxxxxxxxxx>
> 
>     To:
> 
> 	
> platform-ui-dev@xxxxxxxxxxx,
> 
>     Date:
> 
> 	
> 03/04/2014 06:39 AM
> 
>     Subject:
> 
> 	
> Re: [platform-ui-dev] M6 open bugs
> 
>     Sent by:
> 
> 	
> platform-ui-dev-bounces@xxxxxxxxxxx
> 
> ------------------------------------------------------------------------
> 
> 
> 
> Hi,
> 
> I wonder what happened to
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=398837. Eric mentioned he
> wanted to push something yesterday but nothing happened.
> 
> Tom
> 
> On 04.03.14 12:32, Paul Webster wrote:
>> Just a reminder that master is now closed for M6.
>>
>> I've moved most of our bugs that were still open to M7.  We only have a
>> handful of bugs left that we need to address [1], I left them open
>> because it looks like code might have been submitted for them.
>>
>> I need everybody to:
>>
>> 1) look at any of your bugs that are still on that list, and either mark
>> them as fixed and verify them, move them out of M6, or post why it's
>> still valuable to fix it for M6 (regressions found in testing usually).
>>
>> 2) if a bug I just moved out of M6 was actually fixed, please move it
>> back into M6 and mark it as fixed.
>>
>> Later,
>> Paul
>>
>> [1]
>>
> https://bugs.eclipse.org/bugs/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&classification=Eclipse&component=IDE&component=Runtime&component=UI&list_id=8431223&product=Platform&query_format=advanced&target_milestone=4.4%20M6
>>
>> --
>> Paul Webster
>> Hi floor.  Make me a sammich! - GIR
>>
>>
>> _______________________________________________
>> platform-ui-dev mailing list
>> platform-ui-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
>>
> 
> _______________________________________________
> platform-ui-dev mailing list
> platform-ui-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
> 
> 
> 
> 
> 
> _______________________________________________
> platform-ui-dev mailing list
> platform-ui-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
> 



Back to the top