[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [platform-ui-dev] Deprecating IDialogConstants.BUTTON_HEIGHT
|
As far as I remember these constants were introduced to ensure that buttons
have
a minimal height and width. The problem was that buttons with text like OK
looked
ugly under Windows.
I am in favour of getting rid of these constants but I have a couple of
questions:
- how do we make sure that buttons have a minimal height then (under
Windows)
- what will happen to the constants BUTTON_WIDTH and BUTTON_MARGIN.
We should either keep all constants or remove/deprecate them all.
Dirk
Billy Biggs
<vektor@dumbterm.
net> To
Sent by: platform-ui-dev@xxxxxxxxxxx
platform-ui-dev-a cc
dmin@xxxxxxxxxxx
Subject
[platform-ui-dev] Deprecating
13.09.2004 17:10 IDialogConstants.BUTTON_HEIGHT
Please respond to
platform-ui-dev@e
clipse.org
JFace currently uses a constant number of dialog units for button
height. This causes problems on platforms which have buttons that are
larger than on Windows, either with a larger border or added padding
outside of buttons. An example of this is bug 68568, where certain GTK+
themes add enough padding to make buttons unreadable using JFace's hint.
A good cross-platform solution that still uses dialog units is
challenging, since the concept does not fit well under GTK+ and MacOS X.
Instead, I have checked in code which stops using the BUTTON_HEIGHT
constant in favour of just using the default height from SWT. This
seems to fix the problem, removes code, and does not seem to adversely
affect dialog layout in other ways.
Please let me know if this causes problems or unpleasing layouts. If
this goes well in M2 I would like to deprecate the constant.
-Billy
_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/platform-ui-dev
