Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [platform-ui-dev] Parameterized Commands (was 'Key Binding Problem')


"IKeyBindingService always had an unregisterAction method, but no one used it properly, instead relying on 'set and forget' - something the API doesn't even guarantee. We will be asking people to remove their handlers when their part is disposed."

Why do you say that no one used it properly?  There was one instance of the keybinding service per EditorPart. There is every expectation that this instance is going to be thrown away with the editorpart, and there is nothing in the API to indicate that removeAction should have been called. That would be like the SWT team saying you need to remove all MouseListeners when a Control is disposed. The existence of a remove (unregister) method doesn't imply that you must call it.

-Randy

Back to the top