Re: [platform-ui-dev] Toolbar action inconsistencies

[Randy Hudson <hudsonr@xxxxxxxxxx>]

Here are some related thoughts:
Actions must have an icon on the toolbar,
less frequently in the menubar, and rarely in context menus.  See
"Paste" or "Add Breakpoint" for examples of this.

So, if I'm just adding Actions to different
ContributionManagers, how do I control whether an Icon is displayed or
not? Similarly, if the Toolbar ever supported a "use large icons"
setting for 20x20 pixel Icons, how will the Action provide those? It seems
like the separation of Action and ActionContributionItem isn't really clean-cut.
 You often need to know the UI context (menu vs. toolbar).

Maybe there should be a way to contribute
a ContributionItem instead of an Action (if there isn't already). This
could solve some of the problems mentioned by Kevin. For example, creating
a Combo on the Toolbar.

"Simon Arsenault" <Simon_Arsenault@xxxxxxx> Sent by: platform-ui-dev-admin@xxxxxxxxxxx 11/20/2002 10:03 AM Please respond to platform-ui-dev

To:        platform-ui-dev@xxxxxxxxxxx         cc:                 Subject:        Re: [platform-ui-dev] Toolbar action inconsistencies

See my comments below...

Simon :-)



                    
                     
                     
                     
                     
                 
                    
 "Cornell, Kevin"            
                     
                     
                     
         
                    
 <kcornell@xxxxxxxxxxxx         To:  
   "'platform-ui-dev@xxxxxxxxxxx'" <platform-ui-dev@xxxxxxxxxxx>
  
                    
 >                  
           cc:        
                     
                     
                 
                    
 Sent by:                
      Subject: [platform-ui-dev] Toolbar action inconsistencies
               
                    
 platform-ui-dev-admin@            
                     
                     
                     
   
                    
 eclipse.org                
                     
                     
                     
          
                    
                     
                     
                     
                     
                 
                    
                     
                     
                     
                     
                 
                    
 11/19/02 12:19 PM              
                     
                     
                     
      
                    
 Please respond to              
                     
                     
                     
      
                    
 platform-ui-dev              
                     
                     
                     
        
                    
                     
                     
                     
                     
                 
                    
                     
                     
                     
                     
                 



I have noticed some inconsistencies (or incompleteness) in how actions
are
defined in XML (plugin.xml/fragment.xml).

Action Sets (org.eclipse.ui.actionSets)
- The "pulldown" attribute enables an action in the toolbar to
have an
associated drop-down menu. Unfortunately, it appears impossible to define
the contents of that menu in XML. The pulldown menu contents are defined
in
code by calling IWorkbenchWindowPulldownDelegate.getMenu(). It should be
possible to define the pulldown menu completely in XML.

SA> Please enter an enhancement request for this. It's something that
is
missing for sure.

- An action defined in the toolbar should be able to use a combobox (e.g,
for a list of font names, font sizes, etc.)
SA> There is  already a problem report open for this (22642)

Editor Actions (org.eclipse.ui.editorActions)
- Although an accelerator can be defined for an editor action, the XML
does
not allow the "definitionId" attribute to be defined as actions
in an
action set.

SA> Please enter another bug report for this one

- Editor actions defined for the main toolbar cannot define the "pulldown"
attribute. Pulldown actions in the toolbar should be supported, along with
a mechanism to completely define that pulldown menu in XML.

SA> Please enter another bug report for this one too

- An editor action defined in the toolbar should be able to use a combobox.

SA> Please enter another bug report for this one too


View Actions (org.eclipse.ui.viewActions)
- View actions defined for its local toolbar cannot define the "pulldown"
attribute. Pulldown actions in this toolbar should be supported, along
with
a mechanism to completely define that pulldown menu in XML.

SA> Please enter another bug report for this one too

- A view action defined in its local toolbar should be able to use a
combobox.

SA> Please enter another bug report for this one too

Are there any plans to add this functionality to 2.1 and should I log a
feature request bug?

SA> Enter a bug/enhancement report for each of these. We will look at
them
and if we decide we can fix some/all for 2.1, we will mark the milestone
field.

Kevin


------------------------------------------
Kevin Cornell
Senior Staff Software Engineer,
Rational Suites Group


R a t i O n a l
the software development company
770 Palladium Drive
Kanata (Ottawa), Ontario, K2V 1C8
Canada


E-mail *:  kcornell@xxxxxxxxxxxx
Office ':  613.599.3919
Fax:          613.591.7020




_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/platform-ui-dev