Re: [platform-ui-dev] Plugin reorg and preferences

["Knut Radloff" <knut_radloff@xxxxxxx>]

So what exactly changed wrt preferences? Comparing the changes between 
versions is not possible because of the plugin reorg.
The second point is still a problem though. Plugins try to read 
preferences in org.eclipse.ui that are now stored in 
org.eclipse.ui.workbench.
I opened bugs 24292 and 24293 for this.

Knut





"Tod Creasey" <Tod_Creasey@xxxxxxx>
Sent by: platform-ui-dev-admin@xxxxxxxxxxx
10/01/02 02:31 PM
Please respond to platform-ui-dev

 
        To:     platform-ui-dev@xxxxxxxxxxx
        cc: 
        Subject:        Re: [platform-ui-dev] Plugin reorg and preferences


Eduardo has addressed this for todays build Knut. You shouldn't lose
anything.

Tod



  
                      "Knut Radloff"   
                      <knut_radloff@xxxxxxx>         To: 
platform-ui-dev@xxxxxxxxxxx 
                      Sent by:                       cc:    
                      platform-ui-dev-admin@         Subject: 
[platform-ui-dev] Plugin reorg and preferences 
                      eclipse.org   
  
  
                      10/01/2002 02:10 PM   
                      Please respond to   
                      platform-ui-dev   
  
  



Did anyone consider the effects of the plugin reorg on preferences?
Most preferences are stored in WorkbenchPlugin.getDefault() which now is
org.eclipse.ui.workbench instead
of org.eclipse.ui. This means that preferences that were previously stored
in org.eclipse.ui are lost.
In addition, some parts of the ui use
Platform.getPlugin(PlatformUI.PLUGIN_ID) to read preferences that are
stored using WorkbenchPlugin.getDefault(). This is obviously wrong and
leads to preferences being ignored.  Examples are ResourceNavigator and
BasicNewProjectResourceWizard.

I think we have some cleaning up to do. Namely:
-plugins that store preferences in org.eclipse.ui but do not prereq
org.eclipse.ui (e.g., TextEditor in org.eclipse.ui.editors).
-org.eclipse.ui referencing preferences in org.eclipse.ui that are managed
by e.g., preference pages in org.eclipse.ui.workbench

Do we have to look at every place that accesses preferences or is there
some simple solution to this. E.g., do we even have to honor plugin
dependencies when dealing with preferences?

Knut
_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/platform-ui-dev




_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/platform-ui-dev