[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [platform-ui-dev] Question on implementing CellEditor manager
|
I agree that committing as soon as possible is much safer:
a) the user may not realize the cell editor is still open, as in the
TextCellEditor. The only UI change is a 1-pixel shift in the Text.
b) The EditorPart won't get dirtied soon enough; allowing Editors to be
closed without saving.
c) The later the apply, the higher probability for bugs in the
application's code (such as "stale" selection input).
But, I've investigated some more, and a CellEditor whose control is a
Composite will never have focus or can lose focus to one of its children
components. Therefore, it is only the CellEditor that can really know when
focus has been lost, and not the cell editor "manager". I think
CellEditors should be changed to this behavior.
Add your comments to:
http://dev.eclipse.org/bugs/show_bug.cgi?id=10947
http://bugs.eclipse.org/bugs/show_bug.cgi?id=12039
