Re: [platform-swt-dev] Looking for additional reviewers - builder classe

[Stephan Aßmus <superstippi@xxxxxx>]

Hi,

Am 23.10.2018 um 11:23 schrieb Lars Vogel:
> Stephan, please add your feedback to the Gerrit review.

For that I need an account and it wasn't immediately obvious to me how 
to create one. There was no "register" link and thus I thought this is 
only for people who are already committers.

Best regards,
-Stephan

> Stephan Aßmus <superstippi@xxxxxx <mailto:superstippi@xxxxxx>> schrieb 
> am Di., 23. Okt. 2018, 10:17:
>
>     Hi,
>
>     Am 23.10.2018 um 09:40 schrieb Eric Williams:
>      > We have a patch in gerrit to add support for builder/factory classes
>      > into SWT: https://git.eclipse.org/r/#/c/131348/
>      >
>      > Please take a look if you have a moment!
>
>     I think the setters should be named set*().
>
>     And perhaps it isn't as nice as it could be. There is no way to switch
>     from one type of builder to another, and to express the layout of
>     the UI
>     in the code. Something like this would be nice:
>
>     void createUI(Composite parent) {
>           WidgetBuilder.startVGroup(parent)
>               .startHGroup()
>                   .addLabel()
>                       .setText("Text:")
>                       .end()
>                   .addText()
>                       .setLimit(10)
>                       .end()
>                   .end()
>               .startHGroup()
>                   .addGlue()
>                   .addButton()
>                       .setText("OK")
>                       .end()
>                   .end()
>               .end();
>     }
>
>     There are of course numerous alternative ways for the above, of which
>     the pros and cons can be discussed. But if the end result is the
>     possibility for such a construct, it would be nice.
>
>     Best regards,
>     -Stephan
>     _______________________________________________
>     platform-swt-dev mailing list
>     platform-swt-dev@xxxxxxxxxxx <mailto:platform-swt-dev@xxxxxxxxxxx>
>     To change your delivery options, retrieve your password, or
>     unsubscribe from this list, visit
>     https://dev.eclipse.org/mailman/listinfo/platform-swt-dev
>
>
>
> _______________________________________________
> platform-swt-dev mailing list
> platform-swt-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/platform-swt-dev