|
I do understand that the service segment has to be increased. I just don't have the time right now to do that change.
As to the question: "Are the binary files with only whitespace changes different?"
I can't and won't answer this (change is far to big to manually check this).
By contrast I was asking you, if one of the reports answers this question for me, to give additional safety for this huge change. Call me paranoid as not 100% trusting the remove whitespace cleanup :)
I'm less worried about how I can help the reports to get green, but about how the reports can help me.
Is my question clearer now?
Stephan
Am 2020-03-20 11:03, schrieb Daniel Megert:
Hi Stephan
Are the binary files with only whitespace changes different? If so, I presume the comparator is smart enough to ignore that. The repository report looks at all files, not just class files.
As mentioned by Mickael and Lars, the service segment has to be increased.
Dani
From: Stephan Herrmann <stephan.herrmann@xxxxxxxxx>
To: platform-releng-dev@xxxxxxxxxxx
Date: 20.03.2020 10:42
Subject: [EXTERNAL] Re: [platform-releng-dev] is a whitespace change a change?
Sent by: platform-releng-dev-bounces@xxxxxxxxxxx
Thanks Lars & Mickael,
I'm still curious to learn if I'm reading the comparator logs correctly: I need to be sure that the resulting class files have not change at all (the change should preserve even line numbers!).
Stephan
On 20.03.20 10:37, Mickael Istria wrote:
Hi Stephan,
Indeed, if there are visible change in the output, including source bundle or line numbers info (which are affected by whitespace changes), the you need to increase bump the version by +0.0.100 even if it doesn't bring new features or bugfix.
So yes, from Git and from our delivery POV, a whitespace change is a change.
_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-releng-dev
_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-releng-dev
|
