Re: [platform-releng-dev] is a whitespace change a change?

[Mat Booth <mat.booth@xxxxxxxxxx>]

Doesn't the qualifier increase come from tycho-buildtimestamp-jgit? AIUI any change to a file that is not excluded by the "jgit.ignore" property will cause the qualifier to be bumped: https://wiki.eclipse.org/Tycho/Reproducible_Version_Qualifiers

On Fri, 20 Mar 2020 at 10:04, Daniel Megert <daniel_megert@xxxxxxxxxx> wrote:

Hi Stephan

Are the binary files with only whitespace changes different? If so, I presume the comparator is smart enough to ignore that. The repository report looks at all files, not just class files.

As mentioned by Mickael and Lars, the service segment has to be increased.

Dani



From:        Stephan Herrmann <stephan.herrmann@xxxxxxxxx>
To:        platform-releng-dev@xxxxxxxxxxx
Date:        20.03.2020 10:42
Subject:        [EXTERNAL] Re: [platform-releng-dev] is a whitespace change a change?
Sent by:        platform-releng-dev-bounces@xxxxxxxxxxx

---

Thanks Lars & Mickael,
I'm still curious to learn if I'm reading the comparator logs correctly: I need to be sure that the resulting class files have not change at all (the change should preserve even line numbers!).
Stephan
On 20.03.20 10:37, Mickael Istria wrote:
Hi Stephan,

Indeed, if there are visible change in the output, including source bundle or line numbers info (which are affected by whitespace changes), the you need to increase bump the version by +0.0.100 even if it doesn't bring new features or bugfix.
So yes, from Git and from our delivery POV, a whitespace change is a change.

_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-releng-dev
_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-releng-dev



_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-releng-dev