Re: [platform-releng-dev] Adding bundles to the platform features

[Alexander Fedorov <alexander.fedorov@xxxxxxxxxx>]

From the https://git.eclipse.org/r/#/c/154860/

Alexander Kurtakov

1:09 PM

↩

Patch Set 3: Code-Review+2

Until it's really needed/used by anything in platform I would rather see it being added to https://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/features/org.eclipse.e4.rcp . This should satisfy the "publishing" part.

I think e4.rcp feature won't fit here. The new bundle e4.ui.ide will need core.resources with friends and I plan to extract "e4.platform" feature to resolve this: e4.rcp < e4.platform < platformI plan to move a number of types from "org.eclipse.ui.ide" to "org.eclipse.e4.ui.ide" just after the build will converge.Does this change your opinion?

OK. go on in this case

20.12.2019 12:40, Aleksandar Kurtakov пишет:

On Fri, Dec 20, 2019 at 11:26 AM Alexander Fedorov <alexander.fedorov@xxxxxxxxxx> wrote:

Excuse me, due to a misclick I replied to Mickael personally.

So, as I understood the process if the following:
1) submit patch for eclipse.platform.ui repo adding the bundle to the reactor:
done => https://git.eclipse.org/r/#/c/154733/4/bundles/pom.xml

2) try to get that merged:
done => https://git.eclipse.org/r/plugins/gitiles/platform/eclipse.platform.ui/+/faaa67a7392d9a03751e48666204eef55b33e311

3) than submit the patch for the feature:
done => https://git.eclipse.org/r/#/c/154860/

4) see it failing on Gerrit CI review:
done => https://ci.eclipse.org/platform/job/eclipse.platform.releng-Gerrit/424/console

5) but merge it anyway once other patch is merged:
Unbelievable! :)

Please give me +1 for https://git.eclipse.org/r/#/c/154860/ if my understanding is correct.

I give you -1 as I would rather not see unused things end up in platform-feature for now. There is e4.rcp feature which serves exactly that goal. Being in the same repo even CI should verify everything is fine.

 

Thanks in advance,
AF

20.12.2019 10:51, Mickael Istria пишет:

The build is failing, I think because the new bundle is not yet published. How can I "publish" it without adding to a feature?

You more or less can't do that easily.

What would work is to simulate you're building the bundle and the feature together (like it happens during the regular build). To do so, you could create a "super" pom which references eclipse.platform.ui and eclipse.platform.releng/features/org.eclipse.platform-feature as modules and run `mvn clean verify -Pbuild-individual-bundles...` on it.

HTH

_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/platform-releng-dev

_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/platform-releng-dev

--

Alexander Kurtakov

Red Hat Eclipse Team

_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/platform-releng-dev