Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-dev] What does this mean: The nested job 'message-check' is requesting 'pull-requests: read', but is only allowed 'pull-requests: none'?


On Mon, 28 Aug 2023 at 16:14, Christopher Genly <genly@xxxxxxxxxxxxxxxxx> wrote:
A very thorough reply.  Thanks!

:-)
 

One thing I didn't follow.  At the end you say
>> Note that I had to press Enable and run on the workflows
I don't see enable or run on the pull request page.  Where do I find these?

You won't see that button - it is for project members to make sure that a PR is legitimate before the workflow runs. 

Jonah

 

From: Jonah Graham <jonah@xxxxxxxxxxxxxxxx>
Sent: Monday, August 28, 2023 12:40 PM
To: Christopher Genly <genly@xxxxxxxxxxxxxxxxx>
Cc: Eclipse platform general developers list. <platform-dev@xxxxxxxxxxx>
Subject: Re: [platform-dev] What does this mean: The nested job 'message-check' is requesting 'pull-requests: read', but is only allowed 'pull-requests: none'?
 


On Mon, 28 Aug 2023 at 14:55, Christopher Genly <genly@xxxxxxxxxxxxxxxxx> wrote:
This problem continues to occur.  It appears to be retrying a run every Monday.

https://github.com/chgenly/eclipse.platform/actions/runs/5997504002

Yes - it is scheduled to run on a cron job (I hadn't realized that it was triggered by cron job too)

If you can't ignore the failing runs, you turn off GitHub actions on your fork of eclipse.platform, here is a screenshot on my fork:

image.png
 


>> You can simply ignore the error, but if you can reproduce the error, then filing a bug on https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/issues would be helpful!

I was studiously trying to ignore the error.  But I can't anymore. I don't understand what's going wrong.  If I'm to report this as a bug for the aggregator, I'm not sure what I'd say except to point to the failing codeQL.  I'd like to understand if I caused this, or if it is a bug.

You did not cause this, nor is it really a bug. The GitHub actions workflows are designed to be run on eclipse-platform (as opposed to your fork). Perhaps it is possible to improve the workflows so that they handle running on forks better.
 

>> It looks like the workflow (https://github.com/chgenly/eclipse.platform/blob/master/.github/workflows/ci.yml) has some assumptions that the pushes to master are on Eclipse's own version, rather than your fork.

So you're saying there was a push attempt to master on eclipse-platform/eclipse.platform, rather than chgenly/eclipse.platform?  What are you looking at that tells you this?

No. I am saying that the workflow file is designed to run on pushes to the master branch regardless of which fork. You can see the triggers for the workflow here: https://github.com/chgenly/eclipse.platform/blob/3ac31bef75e781d12071123a52ec033468b12729/.github/workflows/ci.yml#L8
 

>> When you create the Pull Request back to Eclipse the workflows should run as expected

I'm not sure what you mean by this.  There is an existing pull request:

The workflows are running as expected there: 

image.png


 on the PR as you are a first time contributor. Once you get your first PR approved, future PRs will automatically run the workflows.

I hope that helps,
Jonah


 





From: Jonah Graham <jonah@xxxxxxxxxxxxxxxx>
Sent: Friday, August 25, 2023 12:05 PM
To: Eclipse platform general developers list. <platform-dev@xxxxxxxxxxx>
Cc: Christopher Genly <genly@xxxxxxxxxxxxxxxxx>
Subject: Re: [platform-dev] What does this mean: The nested job 'message-check' is requesting 'pull-requests: read', but is only allowed 'pull-requests: none'?
 
Hi Christopher,

It looks like the workflow (https://github.com/chgenly/eclipse.platform/blob/master/.github/workflows/ci.yml) has some assumptions that the pushes to master are on Eclipse's own version, rather than your fork.

You can simply ignore the error, but if you can reproduce the error, then filing a bug on https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/issues would be helpful!

When you create the Pull Request back to Eclipse the workflows should run as expected.

Jonah

~~~
Jonah Graham (he/him)
Kichwa Coders
www.kichwacoders.com


On Fri, 25 Aug 2023 at 14:58, Christopher Genly via platform-dev <platform-dev@xxxxxxxxxxx> wrote:
I just pushed a change to my branch.  This error is reported:
Invalid workflow file: .github/workflows/ci.yml#L16
The workflow is not valid. .github/workflows/ci.yml (Line: 16, Col: 3): Error calling workflow 'eclipse-platform/eclipse.platform.releng.aggregator/.github/workflows/checkMergeCommits.yml@master'. The nested job 'message-check' is requesting 'pull-requests: read', but is only allowed 'pull-requests: none'.

This is from:


What does it mean and how do I fix it?

This is where my fork is:


_______________________________________________
platform-dev mailing list
platform-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev

Back to the top