Re: [platform-dev] Regarding SWT patch reviews

[Lars Vogel <lars.vogel@xxxxxxxxxxx>]

I think the feedback of the PMC was that these requirement are to strong.

I will prepare a Gerrit to make this text more welcoming and add to as
reviewer, Niraj.

Best regards, Lars

On Tue, Apr 16, 2019 at 3:51 PM Niraj Modi <niraj.modi@xxxxxxxxxx> wrote:
>
> Updated FAQ entry: https://www.eclipse.org/swt/faq.php#swtpatchtestingdetailswith below note suggesting the importance of this check list:
> Note: Patches satisfying all the items on the list may/will be reviewed with priority.
>
>
> Regards,
> Niraj Modi
>
>
> From:        "Daniel Megert" <daniel_megert@xxxxxxxxxx>
> To:        "Eclipse platform general developers list." <platform-dev@xxxxxxxxxxx>
> Date:        04/16/2019 06:32 PM
> Subject:        Re: [platform-dev] Regarding SWT patch reviews
> Sent by:        platform-dev-bounces@xxxxxxxxxxx
> ________________________________
>
>
>
> > +1 to Alex opinion. Our target should be to longer the entrance barriers for new contributors not increase them.
> +1 too.
>
> Dani
>
>
>
> From:        Lars Vogel <lars.vogel@xxxxxxxxxxx>
> To:        "Eclipse platform general developers list." <platform-dev@xxxxxxxxxxx>
> Date:        16.04.2019 14:02
> Subject:        Re: [platform-dev] Regarding SWT patch reviews
> Sent by:        platform-dev-bounces@xxxxxxxxxxx
> ________________________________
>
>
>
> +1 to Alex opinion. Our target should be to longer the entrance barriers for new contributors not increase them.
>
> Especially in SWT Win and Mac in which only very few committers are active.
>
>
>
> Aleksandar Kurtakov <akurtako@xxxxxxxxxx> schrieb am Di., 16. Apr. 2019, 13:45:
>
>
> On Tue, Apr 16, 2019 at 2:38 PM Niraj Modi <niraj.modi@xxxxxxxxxx> wrote:
> Hi All,
> In order to speed up the patch review cycle, we have framed a checklist of testing that's needed against an SWT patch submitted for review.
> Here is the complete list that needs to be associated with the patch:
>
> Results of the test snippet (if any) associated with that specified bug.
> Results of the Widget's new behavior(if applicable) as tested with various SWT examples: ControlExample.java, CustomControlExample.java and BrowserExample.java
> For changes done to any specific widget, which all related SWT snippets are covered from the list of: SWT Snippets.
> When adding a new API always add new JUnit tests as separate gerrit patch(as gerrit validation will only succeed when the new API is in master and an IBuild exists)
> For Windows only patch, which all operating systems are covered like Windows7, Windows10(at times specific version of Win10 if applicable)
> For MAC only patch, patch should be tested on latest OS version.
> For Linux only patch, which all GTK versions are covered (GTK3, GTK4 or both) and also if applicable what all desktop managers(gnome, wayland etc..) are covered.
> For patches across multiple platform, the patch should have been tested on all affected platforms.
> Also if you expect some behavior change in Eclipse, always launch Eclipse in self-hosted mode to verify the behavior.
>
>
> Same entry added to SWT FAQ page: https://www.eclipse.org/swt/faq.php#swtpatchtestingdetails
>
> I appreciate the list but we have to tone it down. If all these things are mandated before a patch is even looked at I can assure you that very few people (if anyone) contributes back.  Currently a lot of these verifications happen from reviewers/committers (at least for the GTK port) as it is simply not reasonable to expect someone contributing on their free time to invest in having all the complicated infrastructure to do these checks.
> So all these should become like - "Patches satisfying all the items on the list may/will be reviewed with priority".
>
>
>
> Regards,
> Niraj Modi
> _______________________________________________
> platform-dev mailing list
> platform-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/platform-dev
>
>
>
>
>
> --
> Alexander Kurtakov
> Red Hat Eclipse Team
>
> _______________________________________________
> platform-dev mailing list
> platform-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/platform-dev_______________________________________________
> platform-dev mailing list
> platform-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/platform-dev
>
>
> _______________________________________________
> platform-dev mailing list
> platform-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/platform-dev
>
>
> _______________________________________________
> platform-dev mailing list
> platform-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/platform-dev



-- 
Eclipse Platform project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com