[platform-dev] Regarding SWT patch reviews

["Niraj Modi" <niraj.modi@xxxxxxxxxx>]

Hi All,
In order to speed
up the patch review cycle, we have framed a checklist of testing that's
needed against an SWT patch submitted for review.
Here is the complete
list that needs to be associated with the patch:

• Results of the test snippet (if any) associated with that specified bug.
• Results of the Widget's new behavior(if applicable) as tested with various SWT examples: ControlExample.java, CustomControlExample.java and BrowserExample.java
• For changes done to any specific widget, which all related SWT snippets are covered from the list of: SWT Snippets.
• When adding a new API always add new JUnit tests as separate gerrit patch(as gerrit validation will only succeed when the new API is in master and an IBuild exists)
• For Windows only patch, which all operating systems are covered like Windows7, Windows10(at times specific version of Win10 if applicable)
• For MAC only patch, patch should be tested on latest OS version.
• For Linux only patch, which all GTK versions are covered (GTK3, GTK4 or both) and also if applicable what all desktop managers(gnome, wayland etc..) are covered.
• For patches across multiple platform, the patch should have been tested on all affected platforms.
• Also if you expect some behavior change in Eclipse, always launch Eclipse in self-hosted mode to verify the behavior.

Same entry added
to SWT FAQ page: https://www.eclipse.org/swt/faq.php#swtpatchtestingdetails

Regards,
Niraj Modi