Re: [platform-ant-dev] AddCustomDialog unused field

[Darin Swanson <Darin_Swanson@xxxxxxxxxx>]

I am in the camp that if no one is currently using it, remove it.
In this case, the description was removed from the UI but the underlying "setting" code remains. 
You gotta love the help the compiler is providing in finding these types of "mistakes"

Darins

Jared Burns <jared-eclipse@xxxxxxxxx> Sent by: platform-ant-dev-admin@xxxxxxxxxxx 04/24/03 11:06 AM Please respond to platform-ant-dev

To:        platform-ant-dev@xxxxxxxxxxx         cc:                 Subject:        [platform-ant-dev] AddCustomDialog unused field

AddCustomDialog has a private field, description, that is never read. This 
field is set in the constructor and it looks like clients (us) are passing in 
real values. When we find things like this (I think there are others lurking 
about) do we want to yank them out or change the code to use the fields in 
some way?

I'm inclined to just rip out all references to the unread field. If we want to 
add a description to the UI at some point, it's simple enough to create the 
field again.

- Jared
_______________________________________________
platform-ant-dev mailing list
platform-ant-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/platform-ant-dev