Re: [pde-dev] Warnings about plugin.properties in src.includes

[Curtis Windatt <Curtis_Windatt@xxxxxxxxxx>]

The src.includes is used to add additional
items to the source bundle (if one is generated).  Any files required
for the bundle to run correctly (such as plugin.properties) should be included
in the binary bundle, not the source bundle.  If source folders or
plugin.properties is included in both bundles, it can become confusing
later.  For example, when importing, bundles we bring in all the necessary
files from the binary bundle, then try to add in the extra files from the
source bundle if they are available.  With plugin.properties in both
bundles, the import does not know which one is the correct file to import.

Why do you require the properties file
to be in the source bundle?

Curtis

From:	David M Williams <david_williams@xxxxxxxxxx>
To:	"Eclipse PDE general developers list." <pde-dev@xxxxxxxxxxx>,
Date:	2011/05/02 09:29 AM
Subject:	Re: [pde-dev] Warnings about plugin.properties in src.includes
Sent by:	pde-dev-bounces@xxxxxxxxxxx

---

Searching around, it appears this change was introduced
in bug 286808 [1]. 
Essentially, the argument was, "source folders" (and other things)
are included automatically in source bundle. 

But, I'm not defending it. I find it confusing. I think "src.includes"
means "things to included in the source bundle" (to be used later
used by PDE to relate executable code back to its source) but, the confusing
thing, it this is not necessarily everything that's required to build the
project, from scratch?. Confusing. 

So ... I'd suggest opening a bug if plugin.properties is not included automatically
in a "source bundle" and you have use cases where it needs to
be. 

HTH

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=286808

Thomas
Hallgren ---04/30/2011 01:22:54 AM---On 2011-04-29 22:55, David M Williams
wrote: >

From: Thomas Hallgren <thomas@xxxxxxx>
To: pde-dev@xxxxxxxxxxx
Date: 04/30/2011 01:22 AM
Subject: Re: [pde-dev] Warnings about plugin.properties
in src.includes
Sent by: pde-dev-bounces@xxxxxxxxxxx

---

On 2011-04-29 22:55, David M Williams wrote:
>
> Was there ever a reply ... ? If not, I'll give my guess ... I've always
interpreted these warnings to mean,
>
> "since you have plugin.properties listed in bin.includes, it
is redundant and not necessary to also list in 
> src.includes".
>
> Hope that's close to accurate.
>
If it is, then I must have misunderstood something. AFAIK, the stuff listed
in bin.includes aren't included in my 
generated source bundle. Further more, this warning appears even if I don't
list the plugin.properties in my bin.includes.

- thomas

_______________________________________________
pde-dev mailing list
pde-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/pde-dev
_______________________________________________
pde-dev mailing list
pde-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/pde-dev