Re: [paho-dev] Minor breaking change to Android Service API - Feedback /

["BJ Hargrave" <hargrave@xxxxxxxxxx>]

This is not a binary compatibility issue. The throws information is not part of the method signature for the purposes of binary compatibility. https://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html#jls-13.4.21

 

At most, it is a source compatibility issue and only if the compiler is set to warn/error on catch blocks for checked exceptions the compiler cannot observe being thrown. Checked exceptions are a compile-time construct that does not exist at runtime.

 

So I see no issue with this change.

--

BJ Hargrave
Senior Technical Staff Member, IBM // office: +1 386 848 1781
OSGi Fellow and CTO of the OSGi Alliance // mobile: +1 386 848 3788
hargrave@xxxxxxxxxx

 

 

----- Original message -----
From: "James Sutton1" <james.sutton@xxxxxxxxxx>
Sent by: paho-dev-bounces@xxxxxxxxxxx
To: paho-dev@xxxxxxxxxxx
Cc:
Subject: [paho-dev] Minor breaking change to Android Service API - Feedback / comments welcome
Date: Fri, Feb 10, 2017 10:09 AM
 

Hi All,

 

We've had a pull request on GitHub that removes a lot of unnecessary 'Throws' declarations from the API of the Android Service. These were left in a while ago and are fairly unnecessary  as the API is completely asynchronous and errors are exposed using callbacks.

 

The issue that arises is that developers who are using the Android service will have to remove all of the unnecessary try / catch blocks from their code, I suspect that this will actually be welcome as those try / catch blocks can never actually be called.

 

The Pull request is here: https://github.com/eclipse/paho.mqtt.android/pull/155

 

Does anybody have any issues with us accepting this change or can they see any serious issues that this could cause further down the line? It feels like something that will allow cleaner / more maintainable code for developers so seems like a win-win to me!

 

 

Kind regards,

 

James Sutton
Software Engineer - IoT Foundation - MQTT Open Source Projects
Ops Team - Wimbledon Project

Phone: 01962 815438 | Extension: x372454 E-mail: james.sutton@xxxxxxxxxx Personal Website: www.jsutton.co.uk Find me on:	Hursley Park Hursley, SO212JN United Kingdom

 

IBM United Kingdom Limited Registered in England and Wales with number 741598 Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU

Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
 

_______________________________________________
paho-dev mailing list
paho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/paho-dev