[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [paho-dev] Cross-compilation of Eclipse Paho
|
Hi Ian,
yes, actually it's a side effect, that with this version of the
Makefile it is easier to make the build work properly under the CDT
and its build configurations. Now I would say that the name of the
output directory is not as important to me as a cleaned up Makefile
with support for cross compilation. Therefore I created a new patchset
that keeps the original name of the build directory.
However, it should be possible to override the output directory name
by providing an environment-variable named "blddir" to the build
environment (Ant). To me that sounds like the preferred solution now.
Rainer
On Thu, Feb 5, 2015 at 12:09 PM, Ian Craggs
<icraggs@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> Hi Rainer,
>
> I think what I was missing was that this particular change was to make the
> build work better under the CDT?
>
> Maybe it's as simple as having one switch in the Makefile which says the
> build is being run under Ant? Actually I just realized we can do that
> anyway by setting the blddir environment variable in the Ant job.
>
> Ian
>
>
> On 02/04/2015 10:38 PM, Rainer Poisel wrote:
>>
>> Hi Ian,
>>
>> I think I did not explain very well, what I meant. I have amended your
>> new commit on the "develop" branch:
>> * https://git.eclipse.org/r/#/c/41089/1..2/Makefile
>>
>> The output directory will now always be "/build/output" (please see
>> line 31 of the Makefile), no matter what target platform or build
>> configuration has been chosen. Therefore it works with your Hudson
>> configuration. Configuration settings (BUILD_TYPE, OSTYPE,
>> MACHINETYPE) however, are still regarded in the compilation/linking
>> process.
>>
>> In the future (e. g. one of the next releases) we can think of
>> different configurations and test scenarios. ATM it is sufficient for
>> me to have a "post-build" step where directories are renamed by the
>> caller of the Makefile. I don't know how to do that with an unmanaged
>> CDT project, but I am confident to find a solution soon.
>>
>> On Wed, Feb 4, 2015 at 9:41 PM, Ian Craggs
>> <icraggs@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
>>>
>>> Hi Rainer,
>>>
>>> the situation I want to avoid is having a list of output directory names
>>> in
>>> the Ant job, having to maintain that list and select the right one in the
>>> job. That's just a recipe for more work and bugs.
>>>
>>> If the Ant job detects the output directory dynamically and uses it, I'd
>>> be
>>> happy with that.
>>>
>>> Another alternative would be to change the Hudson job so that it didn't
>>> use
>>> Ant. But that would be a few days' work, and not something I really want
>>> to
>>> look into right now.
>>>
>>> Ian
>>>
>>>
>>> On 02/04/2015 07:49 PM, Rainer Poisel wrote:
>>>>
>>>> Hi Ian and Frank,
>>>>
>>>> thank's for having a look at my commit!
>>>>
>>>> To me having different names for the output directory for the
>>>> different target platforms is quite important because I am compiling
>>>> programs for a few different platforms every day.
>>>>
>>>> However, if you want we could remove the "unique name per target
>>>> platform" change for the output directory in a new patchset and
>>>> configure CDT to rename the build directory to a unique name in a
>>>> post-build step, aside of the things that happen in the Makefile. That
>>>> way, using Eclipse it is possible to have different output
>>>> directories, but by using the Makefile only, it is always the same. I
>>>> guess adapting your tests, CI, etc. to support different platforms
>>>> could be quite an effort.
>>>>
>>>> We could think of having e. g. unit-tests for the different platforms
>>>> in one of the next releases.
>>>>
>>>> Kind regards,
>>>> Rainer
>>>>
>>>>
>>>> On Wed, Feb 4, 2015 at 6:12 PM, Ian Craggs
>>>> <icraggs@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
>>>>>
>>>>> Hi Rainer,
>>>>>
>>>>> you changed the default build directory, which causes the tests not to
>>>>> run
>>>>> in the Ant build, which is why the Hudson verification of the change
>>>>> fails.
>>>>>
>>>>> The change is from:
>>>>>
>>>>> /build/output
>>>>>
>>>>> to
>>>>>
>>>>> build/$(BUILD_TYPE)-$(OSTYPE)-$(MACHINETYPE)
>>>>>
>>>>> This would mean that the Ant configuration file would have to have a
>>>>> different build directory setting for each OS etc. The Hudson build
>>>>> definition could send this in as a parameter, but this to me feels
>>>>> unnecessarily complicated. As this is a temporary directory, is the
>>>>> name
>>>>> that important?
>>>>>
>>>>> Ian
>>>>>
>>>>> On 02/03/2015 08:52 PM, Rainer Poisel wrote:
>>>>>>
>>>>>> Dear list,
>>>>>>
>>>>>> some days ago I published a commit on the eclipse gerrit server that
>>>>>> features multi-core builds (using "make -j"), cross compilation and
>>>>>> some sample build-configurations for Eclipse CDT:
>>>>>> * https://git.eclipse.org/r/#/c/39355/
>>>>>>
>>>>>> As part of this commit the Makefile has been refactored in order to
>>>>>> remove some code-duplication and to reflect involved dependencies
>>>>>> correctly. As the output directory structure of the Makefile changed,
>>>>>> the builds on the Hudson based CI fail.
>>>>>>
>>>>>> Is there a way to make my changes make their way into one of the next
>>>>>> releases? Or is there someone out there who could review my commit?
>>>>>>
>>>>>> Kind regards and thanks,
>>>>>> Rainer
>>>>>> _______________________________________________
>>>>>> paho-dev mailing list
>>>>>> paho-dev@xxxxxxxxxxx
>>>>>> To change your delivery options, retrieve your password, or
>>>>>> unsubscribe
>>>>>> from this list, visit
>>>>>> https://dev.eclipse.org/mailman/listinfo/paho-dev
>>>>>
>>>>>
>>>>> --
>>>>> Ian Craggs
>>>>> icraggs@xxxxxxxxxx IBM United Kingdom
>>>>> Paho Project Lead; Committer on Mosquitto
>>>>>
>>>>> _______________________________________________
>>>>> paho-dev mailing list
>>>>> paho-dev@xxxxxxxxxxx
>>>>> To change your delivery options, retrieve your password, or unsubscribe
>>>>> from
>>>>> this list, visit
>>>>> https://dev.eclipse.org/mailman/listinfo/paho-dev
>>>>
>>>> _______________________________________________
>>>> paho-dev mailing list
>>>> paho-dev@xxxxxxxxxxx
>>>> To change your delivery options, retrieve your password, or unsubscribe
>>>> from this list, visit
>>>> https://dev.eclipse.org/mailman/listinfo/paho-dev
>>>
>>>
>>> --
>>> Ian Craggs
>>> icraggs@xxxxxxxxxx IBM United Kingdom
>>> Paho Project Lead; Committer on Mosquitto
>>>
>>> _______________________________________________
>>> paho-dev mailing list
>>> paho-dev@xxxxxxxxxxx
>>> To change your delivery options, retrieve your password, or unsubscribe
>>> from
>>> this list, visit
>>> https://dev.eclipse.org/mailman/listinfo/paho-dev
>>
>> _______________________________________________
>> paho-dev mailing list
>> paho-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/paho-dev
>
>
> --
> Ian Craggs
> icraggs@xxxxxxxxxx IBM United Kingdom
> Paho Project Lead; Committer on Mosquitto
>
> _______________________________________________
> paho-dev mailing list
> paho-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/paho-dev
