[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [p2-dev] Funny dependencies in p2.engine
- From: Jeff McAffer <jeff@xxxxxxxxxxxxxxxxx>
- Date: Fri, 3 Dec 2010 11:14:27 -0500
- Delivered-to: email@example.com
my thinking too.
On 2010-12-03, at 7:17 AM, Pascal Rapicault wrote:
> I can only think that this is a mistake.
> On 2010-12-02, at 3:37 PM, John Arthorne wrote:
>> While reviewing code with Dean we noticed org.eclipse.equinox.p2.engine had some unusual dependency practices in its manifest:
>> - In many (but not all) cases, there is both a require bundle and import package for the same dependency
>> - Some of the dependencies expressed a very narrow range while others were larger:
>> require bundle: org.eclipse.equinox.p2.core;bundle-version="[2.0.0,2.1.0)"
>> import package: org.eclipse.equinox.p2.core;version="[2.0.0,3.0.0)",
>> My question is, can anyone think of reasons we would need both package and bundle imports? I thought we had settled on only using package imports between p2 bundles. Also, I think the narrow range is overly conservative even in cases where we use friends or internals between p2 bundles. For example Dean was adding a new, fully compatible API in p2.core, which broke the above bundle dependency, requiring p2.engine to be changed for no good reason.
>> p2-dev mailing list
> p2-dev mailing list