[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[p2-dev] Re: Lots of errors in my error log

I have made some headway with this, however, I'm surprised we have not seen this more often.  It would appear that when we publish bundles into one of the cache's (in this case 834/data/1969065986/) we use the BundlesAction from the publisher.  This action also publishes the translation fragments, however, no FILE_NAME property is set on the translation fragments. This leads to the errors I'm seeing.

There is even a comment to this effect on line 160 of RepositoryListener:
// we only want to return the bundle IU so must exclude all fragment IUs
// not sure if this is still relevant but we should investigate.

The easy fix is not to log the error, that is, just ignore IUs that don't have the FILE_NAME property, but I don't think this is the proper approach.

thoughts,
Ian

On Fri, May 8, 2009 at 9:23 PM, Ian Bull <irbull@xxxxxxxxxxxxxxxxx> wrote:
I noticed that p2 was generating lots of errors in my error log

275274: "translated_host_properties is missing the filename property" error
https://bugs.eclipse.org/bugs/show_bug.cgi?id=275274

I decided to attach a remote debugger to see where these were coming from and appears that they are generated from:

RepositoryListener#synchronizeCurrentFiles()

In that method we loop through a metadata repo, finding all the IUs and grab the FileName property on that IU.  In the case of translation fragments, I don't appear to have a filename, so an error is logged.

Some information about the repository:
location: file:/home/irbull/eclipse/eclipse/configuration/org.eclipse.osgi/bundles/834/data/1969065986/
name: extension location metadata repository: file:/home/irbull/eclipse/eclipse/.eclipseextension
type org.eclipse.equinox.internal.p2.metadata.repository.LocalMetadataRepository

I don't know anything about the FileName property, so I'm pretty much stuck on where to go next.  If anyone has any ideas, please let me know and I will continue to try and debug this issue.

cheers,
ian

--
R. Ian Bull | EclipseSource Victoria | +1 250 477 7484
http://eclipsesource.com | http://twitter.com/eclipsesource



--
R. Ian Bull | EclipseSource Victoria | +1 250 477 7484
http://eclipsesource.com | http://twitter.com/eclipsesource