[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[p2-dev] publisher integration

Thanks to Simon and Ben the changes and testing for adopting the publisher in the directory watcher, extension location, reconciler and update site code have been committed to HEAD. The test have been updated (and all pass). We should see the new function in the nightly build tonight.

Known/expected issues:
- The translation support integration/testing is still underway. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=244421
- The publisher project has discouraged access warnings turned off pending the addition of the publisher as a friend of various bundles. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=244494
- Performance, while on par more or less with the latest Generator based repo listener etc still has some way to go. Good news is that there are some obvious things we can do. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=244628
- Publishing applications: The Generator had one app that pretty much did it all depending on the set of arguments. The new model is to have several simpler apps that are used for specific purposes. Not all of these are implemented but the good news is that they are dead simple to put together.
- PDE build integration and the ant tasks: This is pending Andrew's return. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=243753
- selfhosting integration: This has yet to be started. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=244773


Missed fixes:
I have spent a lot of time syncing the publisher branch with HEAD and integrating any changes that have come in. For the most part code has just moved around unchanged so this was relatively easy. In some areas there has been substantial change. Keeping things in line has been quite challenging and it would not be surprising to find that a few changes have been missed. Please open bug reports for these perhaps with a [publisher] tag on the summary. I am happy to work with people to help track down the missed changes and find the right place to put them in the new code.


Going forward if you fix something in the Generator, please either fix it in the publisher or open a bug against the publisher to have the fix implemented there as well.

Tests:
One of the really cool things about the new design is that it is much easier to test. We (Ben mostly) have started using EasyMock to create mock objects and write tests that are quite isolated and thus easier to setup and run. In updating the p2 test suite I noticed that we can greatly simplify the way we are doing things and make the tests much faster to run as well as easier to maintain and write. The publisher test suite will be released into CVS on Friday. While it is not a paragon of perfection, I do encourage you to take a look at the mock style and think about how we can use that to improve the existing and future tests.


Jeff