[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [orion-dev] Making the Editor easier to reuse
|
Hello Boris!
Le Fri, 28 Oct 2011 00:16:17 +0300, Boris Bokowski <bokowski@xxxxxxxxx> a
écrit:
Hi Felipe (and Silenio),
Mihai wrote:
editor.js:
- We need to be able to enable/disable animations.
I quite like the fact that the Orion editor has the ability to animate
the
scrolling, but I realize that some people perceive it as a waste of time
[1]. What's worse, the animations are not consistent. For example, page
up/page down does not animate.
Agreed.
My gut feeling is that the ability to animate (or not) would be best
moved
into textView.js, instead of trying to implement it at a higher layer.
This
would make it much easier to ensure consistency. What do you think?
I would consider animations as higher level, rather than something at
TextView level. Maybe it's just me.
My reasoning is that the text view widget should provide all capabilities
for the widget itself. For "fancy" features, one would take the editor.
However, it seems that the editor abstraction is also useful for "basics"
like drag and drop support. See discussion in bug 358623. [1]
It's not always easy to draw the line, but I would keep animations in the
editor layer, with the option of disabling them.
One argument I would use for "why no animations?" is because any native
editor I've used lacks animations (eg. gedit, gvim, ultraedit and others).
The disorienting factor is probably why animations don't necessarily fit.
[1] Personally, I'd rather have the editor spend 300 ms showing me how
the
editor contents are changing, than my brain spending roughly the same
time
trying to re-orient itself. Is it just me?
Agreed.
Best regards,
Mihai
[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=358623
