Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [orion-dev] Orion editor development and integration

Hello Felipe!

Thanks for your reply!


Le Tue, 31 May 2011 22:12:29 +0300, Felipe Heidrich <Felipe_Heidrich@xxxxxxxxxx> a écrit:

Hi Mihai,


To run the tests

- Download JsTestDriver.jar from http://code.google.com/p/js-test-driver/

- Run the Orion server on the localhost port 8080
(You can skip this step by changing the jsTestDriver.conf file, replacing
"http://localhost:8080/editor/"; by, for example, "
http://orionhub.org/editor/";)

-From the command line execute:
java -jar JsTestDriver-1.3.2.jar --port 42442 --reset --browser
"/path/to/bin/firefox" --config
"/path/to/your/repo/org.eclipse.orion.client/bundles/org.eclipse.orion.client.editor/jsTestDriver.conf"
--tests all

Thank you! This worked for me.

The web server URL ... is it important for it to run from the orion.server? I have Apache configured to serve the editor from orion.client.editor/web. Is this sufficient?

Let me know if you that works for you.

I agree with your ideas for renaming and moving files around. I will talk
to the owners of the other components and see what they think.
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=347826 and
https://bugs.eclipse.org/bugs/show_bug.cgi?id=337741
Here are some of the changes I was thinking:
eclipse.Editor -> orion.TextView
eclipse.Model  -> orion.TextModel
eclipse.LineNumberRuler -> orion.LineNumberRuler
orion.EditorContainer -> orion.Editor
and so on
(we have not decided yet, but maybe we will use orion.editor.name instead
of just orion.name to avoid conflict in the URI namespace).

Great to see you are working on a better organization. I am looking forward to see the results!


Note that we are also moving to requireJS so the namespace and the URI
namespace will change to match, for example /editor/samples/undoStack.js
will change to /orion/UndoStack.js.
(For the editor component, we will code it so that it works with and
without requireJS)

That sounds good! Keeping things simple is really important for easy integration.


Best regards,
Mihai



--
Mihai Sucan
http://www.robodesign.ro


Back to the top