[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [orion-dev] Orion editor development and integration
|
Hello Susan!
Le Tue, 31 May 2011 19:30:04 +0300, Susan Franklin McCourt
<susan_franklin@xxxxxxxxxx> a écrit:
Hi, Mihai.
The suggestions you are making with respect to grouping the source
editing
features with the editor, and separating it from the rest of orion client
is exactly the kind of "refactoring" Boris mentioned in his first reply.
Thank you for your explanation! We are looking forward to the improved
files organization.
I worked on the Orion integration and I got it working inside our new
developer tool Scratchpad, inside the Mozilla codebase. Results:
- a patch that adds the Orion code into Mozilla's codebase.
https://bugzilla.mozilla.org/show_bug.cgi?id=660784#c2
- another patch with the glue-code that makes Mozilla's Scratchpad
developer tool to use the new SourceEditor (Orion):
https://bugzilla.mozilla.org/show_bug.cgi?id=636727#c2
Please look into the comments and the patches if necessary, to see how we
are using Orion, the concerns and the implementation "report". I have
noted in the comments some of the things we need to tackle in the Orion
"world" (like line wrapping, insertText()). If we decide that the iframe
workaround is a problem, we'll also look into changing the calls to
createElement() in Orion.
Any comments and suggestions from the Orion developers are very much
welcome and appreciated!
- submitted a pull request to support custom context menus in the Orion
editor component:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=334583#c2
Thank you again!
Best regards,
Mihai
--
Mihai Sucan
http://www.robodesign.ro
