[orbit-dev] Fwd: new process for 3rd party dependencies

[Matthias Sohn <matthias.sohn@xxxxxxxxx>]

forwarding Wayne's reply to the orbit-dev list since this is relevant also for other additions to Orbit

---------- Forwarded message ---------
From: Matthias Sohn <matthias.sohn@xxxxxxxxx>
Date: Wed, Oct 30, 2019 at 1:26 AM
Subject: Re: new process for 3rd party dependencies
To: Wayne Beaton <wayne.beaton@xxxxxxxxxxxxxxxxxxxxxx>

On Tue, Oct 29, 2019 at 8:40 PM Wayne Beaton <wayne.beaton@xxxxxxxxxxxxxxxxxxxxxx> wrote:

Hi Matthias.

We've only just started down this path, so we don't have very much documentation outside of my blog post. I should hopefully have more information available early next week.

We're still working on the prototype tool, but do hope to have it available for testing early next week as well. I've added Eclipse JGit to my tests and am happy to see that (with a couple of tweaks), it works as expected (i.e. it reports that JGit is clean). I have a little more work to do with Eclipse EGit, but am confident that I'll have it sorted out shortly (I may ask for your help).

ok, looking forward to try the tool

 

That you need to pass the content through Eclipse Orbit is a case that I haven't thought enough about. The current requirements for contributions to Orbit still apply, so a CQ will still be required. Note that I spoke with Gunnar and Rolland last week at EclipseCon regarding how the processes around Orbit will change, so expect some communication about that in the near future.

You're not going to need a piggyback CQ, but that doesn't really help you much given the current process for getting things into Orbit.

We're going to track the results from the tool as part of the IP Log. For the short term, we'll ask project teams to attach the results from running the tool to the CQ that gets created when they submit an IP Log for review. Longer term (2020), we're going to replace the entire tool chain, so this will (obviously) change. 

More soon.

ok, thanks

 

Wayne

On Sun, Oct 27, 2019 at 1:57 PM Matthias Sohn <matthias.sohn@xxxxxxxxx> wrote:

Hi Wayne,

EGit (and later probably also JGit) wants to migrate to JUnit5 and move from hamcrest to assertj for assertions: https://bugs.eclipse.org/bugs/show_bug.cgi?id=552444

This means we need to add a recent version of assertj to Orbit (the version currently available in orbit is very old) and then start migrating tests.

What are the steps we should follow in the light of the new 3rd party process to implement this ?

Is a first version of the license check tool already available ? How are the results of these checks tracked ?

Is there already any documentation on this ? If not, can we help to create it, maybe on a wiki page ?

-Matthias

--

Wayne Beaton

Director of Open Source Projects | Eclipse Foundation, Inc.