Re: [orbit-dev] Adding an existing bundle from Maven to Orbit

[Roland Grunberg <rgrunber@xxxxxxxxxx>]

I think I have it working in the following way :

1) A new feature project, say aggregationfeature-unwrapped, is built first.
It uses pomDependencies=consider (depends on glazedlists). In
tycho-source-feature-plugin,
it lists glazedlists in excludes. This is so that we don't attempt to
download and use as-is the
source bundle for glazedlists.

2)  In the glazedlists/ca.odell.glazedlists_1.11.0/ folder, we leave
it as-is and build all of
orbit-recipes bundles. This will install the galzedlists source bundle
which we need. It'll also
install the glazedlists main bundle it generated, but it will be
ignored as (1) already locked
onto the one from maven.

3) In the aggregationfeature, we add a plugin entry for
'ca.odell.glazedlists.source' in the
feature.xml. In the tycho-source-feature-plugin of the
aggregationfeature (actually
inherrited from releng/mavenparent/pom.xml) we add an exlucsion on
'ca.odell.glazedlists.source'. We can now build the aggregationfeature
and it will use the
source bundle, while not trying to look for ca.odell.glazedlists.source.source.

4) Now in releng/repository, we just need to add yet another
pomDependencies=consider
along with (glazedlists). Makes me realize we could have probably just
gotten rid of the
special unwrapped feature and built directly into the
eclipse-repository. But either way, once the
feature is added to the category, it all seems to work.

But now, the glazedlists main bundle is not packed or signed because
that process is
(currently) built into the eclipse-bundle-recipe type. Is it possible
to sign it somehow ?

On Fri, Sep 20, 2019 at 3:02 PM Dirk Fauth <dirk.fauth@xxxxxxxxxxxxxx> wrote:
>
> OK, I have to admit that I was not aware of the fact that the source bundle also has to be an OSGi bundle.
>
> I think that sources are important. Especially because companies nowadays need to perform OSS scans. And of course for debugging purposes.
>
> As all the other resources are also wrapped, I suppose I should not push the direction any further and simply accept that the OSGi bundle gets wrapped to be consumable via Orbit.
>
> Or would it be possible to only wrap the source bundle?
>
> On Fri, Sep 20, 2019 at 8:07 PM Gunnar Wagenknecht <gunnar@xxxxxxxxxxxxxxx> wrote:
>>
>> > On Sep 20, 2019, at 16:48, Roland Grunberg <rgrunber@xxxxxxxxxx> wrote:
>> >
>> > On Fri, Sep 20, 2019 at 8:36 AM Dirk Fauth <dirk.fauth@xxxxxxxxxxxxxx> wrote:
>> >> I think creating such a feature would work. I could give it a try with the example I provided.
>> >
>> > You're right pomDependencies=consider could work and could
>> > get resolved by a separate feature. There's one issue though, in
>> > the case of glazedlists. com.glazedlists:glazedlists:1.11.0:sources
>> > is not an OSGi bundle, so source feature generation fails.
>>
>>
>> Bummer. I don't expect any of the ready-to-use bundles to have a source bundle for Eclipse. Thus, this feature either needs to disable source generation (we won't ship sources for it) or we need to continue wrapping the bundles for the purpose of having source.
>>
>> -Gunnar
>>
>>
>> --
>> Gunnar Wagenknecht
>> gunnar@xxxxxxxxxxxxxxx, http://guw.io/
>>
>>
>> _______________________________________________
>> orbit-dev mailing list
>> orbit-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>> https://www.eclipse.org/mailman/listinfo/orbit-dev
>
> _______________________________________________
> orbit-dev mailing list
> orbit-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/orbit-dev