Re: [orbit-dev] Lucene 5.2.1 into orbit-recipes (EBR)

["David M Williams" <david_williams@xxxxxxxxxx>]

Instead of "disabling", would
"optional" be better? At least for now? 
(I'm assuming by "disabling"
you mean you just left out of MANIFEST.MF file.)
That might still not be technically
correct ... but, seems better than not mentioning at all. 
Being "optional" might allow
some "early testing", before everything was corrected in Orbit,
at which time you'd want to remove the "optional". 

Since I had to look them up, if anyone
else is interested, relevant bugs are 

https://bugs.eclipse.org/bugs/show_bug.cgi?id=465874
and 
https://bugs.eclipse.org/bugs/show_bug.cgi?id=466829

That's probably where most of this discussion
should take place. 

Thanks, 




From:      
 Roland Grunberg <rgrunber@xxxxxxxxxx>
To:      
 Orbit Developer discussion
<orbit-dev@xxxxxxxxxxx>, 
Date:      
 10/08/2015 10:35 AM
Subject:    
   Re: [orbit-dev]
Lucene 5.2.1 into orbit-recipes (EBR)
Sent by:    
   orbit-dev-bounces@xxxxxxxxxxx

---

> Hi Roland,
> 
> out of curiosity: Which bundles are you going to contribute?
> 
> And if you plan on contributing org.apache.lucene.queryparser (which
is
> currently on my mind), how do you handle its dependency to
> org.apache.lucene.sandbox, which in turn depends on org.apache.regexp
> (AFAIK, retired as of 2011 [1])?

The bundles I have contributed are exactly those listed in Bug 465874 [1].
Yes, one of them is lucene-queryparser, and for now I have removed the
dependence to lucene-sandbox, and lucene-queries [2]. While packaging I
was a little concerned when I couldn't find any current CQs for sandbox
or queries, but was assured that at least for the platform usage
(platform.ua ?), they would not be needed.

Now I'm seeing that CQs for sandbox and queries were filed as #10160, and
#10161 just a few days prior to me pushing those 4 bundles.

So if these are destined for Orbit, there would need to be some agreement
with platform.ua since the platform would be gaining some additional lucene
bundles, and I would have to remove my disablement in lucene-queryparser.

Cheers,
-- 
Roland Grunberg

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=465874#c17
[2] http://git.eclipse.org/c/orbit/orbit-recipes.git/diff/lucene/org.apache.lucene.queryparser_5.2.1/osgi.bnd?id=6ca2ee1f0e99d8592badc14e76ef7498647b3d09
_______________________________________________
orbit-dev mailing list
orbit-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/orbit-dev