[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [nattable-dev] column reorder drag feature, release planning
|
Hi Dirk,
Thanks for checking in your changes. I think the sort model disposal should be ok; when NatTable is disposed it will GC the transitive closure of all of the objects it owns, which will include the layer stack and the sort model. I think we only really need an explicit dispose when we're creating resources that cannot be disposed automatically, e.g. native SWT resources, threads.
Also: I got some feedback from the Eclipse folks and they're short staffed right now so they can't give us an ETA yet for the completion of the NatTable IP review. So in the meantime let's go forward with a 0.9 incubation release.
Thanks,
Edwin
On Thu, Aug 9, 2012 at 3:24 AM, Dirk Fauth
<dirk.fauth@xxxxxxxxx> wrote:
Hi,
I just pushed my modifications. I also added a DynamicColumnExample to show how and that it works. There is maybe one issue with cleaning up as you mention that. The GlazedListsSortModel is adding itself as a ILayerListener to the column header data layer. But as the ISortModel has no dispose() method, it is never removed. I'm not sure if this is an issue though, as the ISortModel should be thight coupled to the column header, but I guess we should consider that and find a way to cleanup there too. Any suggestions?
Greez,
Dirk
On Wed, Aug 8, 2012 at 6:15 PM, Edwin Park
<esp@xxxxxxxxxx> wrote:
Hi Dirk,
I commented on the bug you mentioned - I'm all in favor of your fix.
One other thing I forgot to mention: I added a dispose() method to ILayer so that layers have an opportunity to clean up resources. I used this to clean up the schedulers used in the BlinkLayer and in the ViewportLayer. Stefan - I just noticed you posted a bug about the scrollbar listeners not getting disposed. You can use this to do the cleanup there too.
Thanks,
Edwin
On Wed, Aug 8, 2012 at 3:07 AM, Dirk Fauth
<dirk.fauth@xxxxxxxxx> wrote:
Hi Edwin,
sounds nice. As I am working on a bigger project that uses NatTable at the moment, I will check out the changes and have a closer look at it.
I agree that it is time to bring out a release as there are quite an amount of added features and fixed bugs. Speaking of this, could you please have a look at https://bugs.eclipse.org/bugs/show_bug.cgi?id=385171 ?
I have the fix only locally at the moment, and I don't see any issues with it. But maybe I have forgotten something. If you agree with my proposed fix I can check it in so you can have a closer look.
Greez,
Dirk
Hi all,
I just checked in a fix to bug 383555: Scroll on column drag. Now if you drag a column to reorder it and hover over the first or last 10 pixels of the viewport, the viewport will scroll in that direction so you can reorder a column to a location not initially visible in the viewport. I found and fixed a few issues in the ViewportLayer along the way around the logic that tries to keep the maximum number of columns visible in the viewport at all times. I also had to divide the ColumnReorderCommand into Start and End varieties so that the column start location is preserved when the viewport is shifted. Let me know how it works out for you.
At this point we've accumulated quite a number of bug fixes/feature additions and I think it's high time to do a release. I put out a query to the Eclipse IP folks to see when our NatTable CQ might get cleared so we can get out of incubation, but I'm guessing we may have to do an incubation release while we're waiting for that to happen. I'd like to target a release for early September, let me know your thoughts on this.
Thanks,
Edwin
nattable-dev mailing list
nattable-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/nattable-dev
_______________________________________________
nattable-dev mailing list
nattable-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/nattable-dev
_______________________________________________
nattable-dev mailing list
nattable-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/nattable-dev
_______________________________________________
nattable-dev mailing list
nattable-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/nattable-dev
