Re: [mylyn-dev] moving https://git.eclipse.org/r/#/c/44638/ forward ?

[David Green <david.green@xxxxxxxxxxx>]

Max,

Apologies but it's been a busy time and I haven't had a chance to provide a review.  

Generally you'll find turn-around on reviews is much faster if the reviews have 300 lines of code or less (1500+ lines of code is *very* difficult to review).  It would be really helpful if you followed my last comment:

How about cutting this down to just the language class, it's bare necessities and a paragraph block? That would make it easy to add corresponding tests, and would keep the review quite small. Subsequent reviews could introduce one or two additional blocks at a time, making each review self-contained with the corresponding test coverage.

Ideally that would result in small incremental reviews.

David 

On Wed, Apr 8, 2015 at 2:05 PM, Max Rydahl Andersen <manderse@xxxxxxxxxx> wrote:

Hey,

How do we get https://git.eclipse.org/r/#/c/44638/ to move forward ?

I've submitted the gerrit update 6 days ago which David Green said should be simple to get CQ done for.

When that is done I can get remaining ~1000 or so lines in as separate commits.

Thank you,
/max
http://about.me/maxandersen
_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mylyn-dev

--

David Green

VP of Architecture, Tasktop

Committer, Eclipse Mylyn

http://tasktop.com