Okey. So I'm now inclined to just retract this since I cannot keep spending time reorganizing basic stuff into small unusable pieces.
I did reduce it below 1000 lines by reducing the test coverage to be included later.
You rejected that and I did nothing but just add the tests you asked for. Now it's above 1000 lines.
There is no additional logic in this stuff. Just the tests.
If you want me to split this up even further this is going to take several weeks to get in and I and you get to spend ages handling manual rebase and merge errors trying to split this up in. 5+ Gerrit reviews. Max,
Apologies but it's been a busy time and I haven't had a chance to provide a review.
Generally you'll find turn-around on reviews is much faster if the reviews have 300 lines of code or less (1500+ lines of code is *very* difficult to review). It would be really helpful if you followed my last comment:
How about cutting this down to just the language class, it's bare necessities and a paragraph block? That would make it easy to add corresponding tests, and would keep the review quite small. Subsequent reviews could introduce one or two additional blocks at a time, making each review self-contained with the corresponding test coverage.
Ideally that would result in small incremental reviews.
David
|
