Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mylyn-dev] asciidoc support

Thanks Max,

I did an initial stab at your change - not much to comment except for that your name is missing here and there. David, what would be the proper way to handle boilerplate code such as plugin.properties? I think it would be better if we were to remove the copyright header from these. At least in new files. It does not make much sense and we keep copying the same old file into new projects.

Best regards,
Torkild

> 18. mar. 2015 kl. 23.16 skrev Max Rydahl Andersen <manderse@xxxxxxxxxx>:
> 
> Hi all,
> 
> During eclipsecon hackathon I submitted https://git.eclipse.org/r/#/c/43633/
> 
> This adds support for Asciidoc in wikitext.
> 
> This is alot of scaffolded code thus the line count gets to 2000+ and
> David Green suggested I submit it in smaller chunks.
> 
> I'm really not a fan of that since it will take me now multiple evenings to submit this in <300 line patches
> and the code submitted will actually not be very functional before at the end.
> 
> But i'm going to try.
> 
> I've now submitted https://git.eclipse.org/r/#/c/44133/ which just contains the minimal bundle/feature setup.
> 
> Zero functionality.
> 
> Can this be reviewed and submitted ASAP so I can continue with the 3-4 extra gerrit reviews adding the full asciidoc feature I submitted first ?
> 
> Thank you,
> /max
> http://about.me/maxandersen
> _______________________________________________
> mylyn-dev mailing list
> mylyn-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/mylyn-dev

--
Torkild Ulvøy Resheim
Consultant / Eclipse Committer / Senior Software Developer
Itema AS - http://itema.no


Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail


Back to the top