Re: [mosquitto-dev] Auth plugin v3 interface seems to be incomplete

[Roger Light <roger@xxxxxxxxxx>]

Hi all,

I believe this is now all sorted out in the fixes branch, which will
be released very shortly.

The message struct being passed to the ACL check function wasn't being
populated fully, this is now working and has an associated test.
The mosquitto_client_*() functions that can be used by plugins have
their own test as well, and access to usernames and client ids has
been fixed.

In terms of backwards compatibility, the code for v2 plugins is
untouched so should work just fine. You can't mix v2 and v3 functions
in the same plugin.

Cheers,

Roger


On 7 August 2018 at 21:30, Wiebe Cazemier <wiebe@xxxxxxxxxxxx> wrote:
> ----- Original Message -----
>> From: "Martin Assarsson" <martin.assarsson@xxxxxxxxxx>
>> To: "General development discussions for the mosquitto project" <mosquitto-dev@xxxxxxxxxxx>
>> Sent: Tuesday, 7 August, 2018 09:14:04
>> Subject: Re: [mosquitto-dev] Auth plugin v3 interface seems to be incomplete
>
>> @Tatsuzo
>> At the moment I still use 1.4.X but plan to use 1.5.X as soon as I see fit.
>> 1. Yes, auth_plugin_v3 concerns only 1.5 and I'm not keen on mixing versions
>> even if it's said to be backwards compatible.
>> 2. Yes, all old variables are still present.
>> 3. The variables posted to my function is only containing null and scanning the
>> code makes it quite obvious.
>> 4. Take a look in ./src/mosquitto_plugin.h from source code. History is
>> available in git.
>> 5. Backwards compatibility should be in place (don't know where I read it
>> though). As said before, I'm not keen on mixing this though.
>
>> @ Wiebe
>> Thanks!
>> I'll take a look at those issues if they affect me in a bad way.
>
> Those issues are Tatsuzo's second question. You said they are available? I mean, I do not see a way to get the username or client ID, as they are stored in a struct defined in mosquitto_internal.h.
> _______________________________________________
> mosquitto-dev mailing list
> mosquitto-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/mosquitto-dev