Hi Ernesto,
Well, it does work with EGit using ssh URL on my side. But since I am a committer, it might be different for external
contributors.
The Papyrus development team should assign your contribution to the appropriate reviewer when they will review and schedule
the open issues.
Best regards.
Florian
De : Ernesto Posse <eposse@xxxxxxxxx>
Envoyé : lundi 26 février 2024 20:48
À : NOYRIT Florian <florian.noyrit@xxxxxx>
Cc : Papyrus Project list <mdt-papyrus.dev@xxxxxxxxxxx>
Objet : Re: [mdt-papyrus.dev] Bug 582940
Hi Florian,
You are right. I forgot to update the upstream branch to refs/for/master. But I still get a permissions error when pushing with EGit (see below).
prohibited by Gerrit: not permitted: create
Counting objects: 446, done
error: branch refs/heads/for/master:
You need 'Create' rights to create new references.
Contact an administrator to fix the permissions
Processing changes: refs: 1
Processing changes: refs: 1
Processing changes: refs: 1, done
But I was able to push using the command-line:
git push papyrus-gerrit HEAD:refs/for/master
I did configure my local branch to push to HEAD:refs/for/master, but apparently that’s not what EGit does. For future reference, is there a way to make it work in EGit? I followed the instructions in the Wiki, but they must be outdated
or missing something.
By the way, I’ve asked Christian Damus, who wrote that code originally to do the code review. Should I add anyone else who knows about the architecture domains manager/merger?
I am not sure but it looks like you try to push to the master branch directly (refs/heads/master).
Thanks for the help. I generated a new HTTP password in my Gerrit settings, but if I push to master, I get this error:
prohibited by Gerrit: not permitted: update
Counting objects: 446, done
error: branch refs/heads/master:
Push to refs/for/master to create a review, or get 'Push' rights to update the branch.
Contact an administrator to fix the permissions
Processing changes: refs: 1
Processing changes: refs: 1
Processing changes: refs: 1, done
Should I try a different branch then?
1/ The Ref mapping should be : HEAD:refs/for/master
2/ If you use Gerrit to share your contribution, you probably won’t need to use a custom branch for your bug.
Hi, I’m following up with my questions last week about submitting a patch to Gerrit. See the questions below. I’d like to know if I have configured Gerrit correctly as I don’t want to mess up the repo.
1) When configuring the local branch for push, I set the remote and push remote to the newly created remote (which I called gerrit), but should I change the upstream branch? The default is set to refs/head/master. I don’t want to mess
any master branch!
2) Is there a convention for naming branches? I see a lot of “bugs/NNNNNN-short-description. That’s what I’ve used. Is that ok?
I was wondering about pushing to Gerrit, because our company is no longer an Eclipse member and my understanding was that it means I am no longer an Eclipse Committer, but in Bugzilla I see my messages with an ECA tick mark, so I guess
I might still be able to push? I’ll give it a try.
As for the future plans, when is the move to Papyrus-Sirius and Papyrus web planned for? Is it for version 7.0? Or later?
Dear Ernesto,
good to hear from you after quite some time!
Concerning the bug, you should still be able to push to gerrit. I don't think, that required to put the general text (I wrote the code ...) in the commit message as it is not very useful when looking at the history. Make sure, a reference to the bug is in
the header of the modified files.
I also like to point out that the architectural framework of "classic" (GMF, XWT) Papyrus will not be used in the long run. The successors Papyrus-Sirius and Papyrus Web use different customization mechanisms.
Best
Ansgar
On 15/02/2024 04:05, Ernesto Posse via mdt-papyrus.dev wrote:
I’ve submitted a new bug report to Bugzilla, Bug
582940, but I accidentally cut the first few paragraphs with the bug description when I pasted it in the Comment textbox. So I’ve added the full description as a new comment, as I cann’t edit my
previous comment.
I’ve also added a full diagnosis of the bug and can submit a patch, but I don’t think I can push it to Gerrit as I am no longer an Eclipse Committer. Should I use a particular patch header
when creating the patch?
Also, according to the guidelines, I should add messages stating that I wrote the code, that it has no cryptography, etc. Where do I write those? In a local git commit comment and then
create the patch from that commit?
_______________________________________________
mdt-papyrus.dev mailing list
mdt-papyrus.dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mdt-papyrus.dev
|
