Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mdt-papyrus.dev] Findbugs & Test results

Hi Christian,

 

I’ve simply enabled the default Findbugs profile for Maven, which, I think, executes all available Findbugs analysis. I’m not familiar with Findbugs; do you know where I can find the Eclipse configuration to see how I can adapt it for the Maven execution? Or, even better, if such a configuration already exists. I couldn’t find one, but I didn’t spend much time on it.

 

Ø  there are issues in “my” code that I would like to suppress with the @SuppressFBWarnings annotation, because, for example, FindBugs doesn’t understand that code it thinks is “uncallable” is actually invoked by reflection.  However, this requires adding a JAR defining this annotation to the classpath, which in turn requires everyone to update their targets (not a big deal if they’re using Oomph!).  What does the team think of that?

I guess we need to experiment this, especially for people who’re not using Oomph :) If that’s only a build-time dependency that’s fine with me (And I suppose it is)

 

Camille

 

De : mdt-papyrus.dev-bounces@xxxxxxxxxxx [mailto:mdt-papyrus.dev-bounces@xxxxxxxxxxx] De la part de Christian W. Damus
Envoyé : jeudi 7 mai 2015 22:15
À : Papyrus Project list
Cc : Papyrus Project list (mdt-papyrus.dev@xxxxxxxxxxx)
Objet : Re: [mdt-papyrus.dev] Findbugs & Test results

 

Thanks for this, Camille.

 

I have some questions:

  • the build reports a lot more issues than the default FindBugs configuration in the Eclipse workbench.  And I prefer the Eclipse configuration because, by and large, it doesn’t report problems in EMF-generated code  ;-)   Is there an easy way for us to align these settings?
  • there are issues in “my” code that I would like to suppress with the @SuppressFBWarnings annotation, because, for example, FindBugs doesn’t understand that code it thinks is “uncallable” is actually invoked by reflection.  However, this requires adding a JAR defining this annotation to the classpath, which in turn requires everyone to update their targets (not a big deal if they’re using Oomph!).  What does the team think of that?

Cheers,

 

Christian

 

 

On Thu, Apr 30, 2015 at 10:39 AM, LETAVERNIER Camille <Camille.LETAVERNIER@xxxxxx> wrote:

Hi all,

 

 

After several months of failures, the Findbugs analysis is back online for Papyrus Master [1].  Please check and try to fix issues when they are reported (There are still several thousands of warnings, so it will take time to cleanup, but that’s a good practice).

 

Additionally, there are still 28 test failures on Master. Most of them are Sequence Diagram failures (~ 20 regressions, apparently due to invalid tests rather than incorrect runtime behavior). There are also some new regressions on Tables (4 total, 3 new), and still one test failure due to the New Project/Model wizard refactoring.

 

[1] https://hudson.eclipse.org/papyrus/job/Papyrus-Master-Analysis/

[2] https://hudson.eclipse.org/papyrus/job/Papyrus-Master-Tests/

 

It would be nice to get a green build around M7 or RC1 J (And I believe we’re not so far away from that)

 

 

Regards,

Camille

 


Back to the top