Re: [mdt-papyrus.dev] what is your opionion about new folders in trunk/j

[SCHNEKENBURGER Remi 211865 <Remi.SCHNEKENBURGER@xxxxxx>]

Hi all,

 

I do partially agree with you both J

 

I do agree for the same structure for junit and standard plugins. It would be easier for developers or externals person interested in code to find the same structure.

For the bundle tests, my feeling is that its place is in junit/plugins/developer. This is the junit tests for a future plugin which would work on setting bundle numbers for the release engineering of Papyrus. Whatever, it is a junit plugin dedicated to developers, I think this should be placed in junit/plugins/developer.

 

But I do not agree for not having a ‘common’ plugin for junit tests. I think this is a good idea to have only one way to copy files to initiate the tests. What Vincent proposes is that util methods like copy files, open editor,  etc, could be placed in a common plugin. Each junit plugin developer could then use these methods to initialize the tests plugins as he needs.

I would agree on the oep.junit plugin name for this shared library of methods.

 

My 2 cents…

Regards,

Rémi

 

 

------------------------------------------------------------------------------------------------------------------------------------------------
Rémi SCHNEKENBURGER
+33 (0)1 69 08 48 48
CEA Saclay Nano-INNOV
Institut CARNOT CEA LIST
Point Courrier n°174
91 191 Gif sur Yvette CEDEX
 
www.eclipse.org/papyrus

 

De : mdt-papyrus.dev-bounces@xxxxxxxxxxx [mailto:mdt-papyrus.dev-bounces@xxxxxxxxxxx] De la part de Cedric Dumoulin
Envoyé : lundi 14 mai 2012 11:35
À : Papyrus Project list
Objet : Re: [mdt-papyrus.dev] what is your opionion about new folders in trunk/junit ?

 

  I disagree :-).

  We must have the same tree structure for Junit and for non-Junit plugins.
  The non Junit plugins are grouped in extraplugins and plugins, with sublayers. So we should have the same for Junit plugins.
  JUnit plugins are in another tree (JUnit) in order to ease the build process. But we should really think as if they are in the same tree than non JUnit plugins.

  We could create a layer "tests" somewhere (ex: inside junit/extraplugins). Your bundles tests will fall in this layer:
org.eclipse.papyrus.tests.bundles
  Maybe a better place for this plugins is oep.developer.tests.bundles, because it is a dev related plugins.

  For JUnit commons classes, helpers, etc, we could create a JUnit layer (in JUnit/plugins):
oep.junit.xxx

  I not really sure that having a "common" plugin for junit tests is a good idea: JUnit tests must be easy to understand and to maintain. Having a "common" plugins could lead to the same problems that we encounter with the other "common plugins": they contains all and everything, and they are used as garbage where we put things that we don't know how to put elsewhere.

  Just my two cents ...

  Cedric
 

LORENZO Vincent a écrit :

Hi all,

Currenlty, on the SVN the folder /trunk/tests/junit has 2 children :

                - extraplugins

                - plugins

 

  I propose to add it 2 new children :

- a folder to store the JUnit tests plugins which can be used for extraplugin and “standard” plugin. This folder should be called ‘common’ or ‘common-tests’ for example.

                my new plugin org.eclipse.papyrus.bundles.tests could be moved to this new folder.

                               (this plugin verify the version, the provider name, the about.html file, …)

- a folder to store plugins which won’t contain JUnit tests, but abstract classes, helpers, … which could be used by the JUnit tests of plugins and extraplugin. This folder should be called ‘utils’ or ‘common-utils’ for example.

 

 

Do you agree with these new folders and their names ?

Best regards,

--

Vincent Lorenzo

01-69-08-17-24

CEA Saclay Nano-INNOV

Institut CARNOT CEA LIST

DILS/LISE

Point Courrier n° 174

91 191 Gif sur Yvette CEDEX

 

_______________________________________________

mdt-papyrus.dev mailing list

mdt-papyrus.dev@xxxxxxxxxxx

https://dev.eclipse.org/mailman/listinfo/mdt-papyrus.dev